-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrades to issue templates #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
.github/ISSUE_TEMPLATE/bug.yml
Outdated
- type: dropdown | ||
id: browser | ||
attributes: | ||
label: "🥦 Browser" | ||
description: "What browser are you using ?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this field is useful for only the website
repo. Is it a good idea to have it in all repos? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well i have the same doubt myself. Depending on browsers, stuffs might break - that's why i put it in, what should i do then ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to mark something as optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the required: true
field can be reverted back to make it optional.
Should I do it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, we can make this optional but I also find this question valuable and I would recommend leaving it in 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli can you have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨✨✨✨ LGTM, lovely work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alequetzalli what about the code of conduct check box you introduced in docs template. I loved that idea. What about having it in these new templates too?
/rtm |
This Pull request closes #212
What i did
.yml
files as issue templates instead of the previous.md
files.md
filesHow to check it
Visit the forked version here and try and make a new issue.
Relevant screenshots