Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrades to issue templates #217

Merged
merged 10 commits into from
Feb 21, 2024
Merged

Conversation

tamalCodes
Copy link
Contributor

This Pull request closes #212

What i did

  • Added new .yml files as issue templates instead of the previous .md files
  • Removed the old .md files

How to check it

Visit the forked version here and try and make a new issue.

Relevant screenshots

image
image
image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@tamalCodes tamalCodes changed the title [FEAT] : Upgrades to issue templates 🛠 feat : Upgrades to issue templates 🛠 Mar 11, 2023
@tamalCodes tamalCodes changed the title feat : Upgrades to issue templates 🛠 feat: Upgrades to issue templates 🛠 Mar 11, 2023
@tamalCodes tamalCodes changed the title feat: Upgrades to issue templates 🛠 feat: upgrades to issue templates Mar 11, 2023
Comment on lines 45 to 49
- type: dropdown
id: browser
attributes:
label: "🥦 Browser"
description: "What browser are you using ?"
Copy link
Member

@KhudaDad414 KhudaDad414 Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this field is useful for only the website repo. Is it a good idea to have it in all repos? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well i have the same doubt myself. Depending on browsers, stuffs might break - that's why i put it in, what should i do then ? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to mark something as optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the required: true field can be reverted back to make it optional.
Should I do it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can make this optional but I also find this question valuable and I would recommend leaving it in 😄

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli can you have a look?

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨✨✨✨ LGTM, lovely work!

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alequetzalli what about the code of conduct check box you introduced in docs template. I loved that idea. What about having it in these new templates too?

@derberg
Copy link
Member

derberg commented Feb 21, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit a10768b into asyncapi:master Feb 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to Issue templates 🛠
5 participants