Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed required from optional to false in bug.yml #273

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

pavanydg
Copy link
Contributor

@pavanydg pavanydg commented Feb 22, 2024

Description

  • changed required from optional to false
    Related issue(s)

"Fixes #271"

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@pavanydg pavanydg closed this Feb 22, 2024
@pavanydg pavanydg reopened this Feb 22, 2024
@pavanydg pavanydg changed the title changed required from optional to false in bug.yml fix: changed required from optional to false in bug.yml Feb 22, 2024
@AnimeshKumar923
Copy link
Contributor

Hi! @pavanydg 👋

In your pr message there's no need to put 'Fixes' in backticks.
It should look like this 👇
"Fixes #271" and not like "Fixes #271" (without the inverted commas)

Otherwise your pr won't be linked to the referenced issue.


Read about more ways to link a pr to an issue here

@derberg
Copy link
Member

derberg commented Feb 26, 2024

@pavanydg thanks for the PR and @AnimeshKumar923 thanks a lot for initial triage 🙏🏼

@derberg derberg merged commit 09d72fb into asyncapi:master Feb 26, 2024
27 of 29 checks passed
@AnimeshKumar923
Copy link
Contributor

@pavanydg thanks for the PR and @AnimeshKumar923 thanks a lot for initial triage 🙏🏼

@derberg my pleasure 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug fix in bug template 😃
3 participants