Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix windows issues in few workflows #280

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

derberg
Copy link
Member

@derberg derberg commented Apr 2, 2024

Description

Related issue(s)

Comment on lines +102 to +109
id: first-installation
run: npm ci
continue-on-error: true
- if: steps.first-installation.outputs.status == 'failure' && steps.packagejson.outputs.exists == 'true'
name: Clear NPM cache and install deps again
run: |
npm cache clean --force
npm ci
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fixing https://github.com/asyncapi/cli/actions/runs/8520415954/job/23336484803

these issues keep repeating, we had this fix for PR testing workflow already

but issue back again npm/cli#7308 and now blocking release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance to reproduce the error locally? Or just possible on Github?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that happens only in windows, on local you could probably try to reproduce by doing the same as described in the error, manually damage local cache

Copy link
Member

@KhudaDad414 KhudaDad414 Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @derberg, It doesn't seems to be working. https://github.com/asyncapi/cli/actions/runs/8530056612/job/23367134751

the Install Dependencies step doesn't report any issues hence, Clear NPM cache... step is skipped and the workflow fails in testing. 🤔

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit f9776ed into asyncapi:master Apr 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if-nodejs-pr-testing.yml does not test on Windows
4 participants