Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed all json-schemas file #184

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

sambhavgupta0705
Copy link
Member

Description
This PR removed all the json-schemas file of the repository

Related issue(s)

Resolves #183

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@KhudaDad414
Copy link
Member

/dnm

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for 3.0 Release :)

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 7, 2023
@sambhavgupta0705
Copy link
Member Author

Still relevant,waiting for spec 3.0 release:)

@github-actions github-actions bot removed the stale label Jun 10, 2023
@jonaslagoni
Copy link
Member

@sambhavgupta0705 you can go ahead and re-target the PR to next-major-spec and then we can get this PR merged ASAP 🙂

@sambhavgupta0705
Copy link
Member Author

@jonaslagoni re targeted the PR

@jonaslagoni
Copy link
Member

@sambhavgupta0705 go ahead and update your PR with latest next-major-spec changes, you should see a button in the bottom of the PR to update.

@sambhavgupta0705
Copy link
Member Author

@jonaslagoni I have updated it now.PTAL

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sambhavgupta0705 aka "el destructor" 🔥

@derberg
Copy link
Member

derberg commented Jun 26, 2023

@jonaslagoni ready to merge, but leaving it up to you when to do it as not sure if you want #183 closed now or later

@jonaslagoni
Copy link
Member

@derberg see no reason why to keep it open :D

If anything we can always add more specific issues for any follow up change needed 🙂

@jonaslagoni
Copy link
Member

/rtm

@jonaslagoni
Copy link
Member

@derberg @fmvilas might need a manual merge 🤔

@fmvilas fmvilas merged commit 77f376e into asyncapi:next-major-spec Jun 26, 2023
@smoya
Copy link
Member

smoya commented Jun 27, 2023

This actually made me laugh 😆

@sambhavgupta0705 aka "el destructor" 🔥

gozer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all JSON Schema files after spec 3.0 release
7 participants