Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: proposed set of bindings for AWS - SNS and SQS #84
docs: proposed set of bindings for AWS - SNS and SQS #84
Changes from 66 commits
b64dcf6
cc91daa
c322a0b
0d2956a
6e6bbb3
af5fa86
325291c
6f939c6
d5493f4
f97af36
94443a0
cada568
471e92a
0c8a141
f82ac68
57d67ed
1139f7a
c7a202a
1690fe5
1d33e72
cfa8115
192c7ce
27829d9
08d2ba2
401ec78
61cc69a
eaa8bec
a7d982f
0f75115
162d72c
6c495ba
a71f798
d7ad6c2
677e095
9fbc3e6
807dc5c
8c3a1fe
f5dbc92
fb4c786
8533ae3
d05406d
d0f3921
d3367a3
414eb68
bfbcdd0
4a6aa9f
d775f18
d2d9da5
a4b440e
504dc1e
08a5bfd
f11a17d
ce32e23
31d0df8
9cc5f83
4e946c5
d78083c
c988dbd
e9d2979
2699386
4bb2c4f
df95b2f
1dedbbe
2912e3b
87c0756
2417fff
bd26fa4
f5b6060
a9fbb73
8c637f4
0f947a6
343fe18
bd462c5
891a4ec
45a5181
c6df5d8
279a08c
5491c71
3e13191
604f8ff
32f6e8c
bf3d591
3f3dc89
49dc0b2
916ce97
9b4d174
3fa08af
7d089e6
25c0134
38a9a3c
edf0563
b780cca
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the AWS documentation for redrive policies it doesn't seem like the target resource to be used for redriving messages is an object but is instead a string that could be an ARN, URL, Name etc.
For example in cloud formation the redrive policy definition looks like this:
Which appears to be fairly representative of how a lot of infrastructure tooling deals with defining redrives.
Is there a reason we are diverging from the common standards for defining redrives with a separate identifier object that has specific properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, it's better to keep the definitions as simple as possible at the beginning. If most infra tooling only uses deadLetterTargetArn and maxReceiveCount for the Redrive Policy then there is no harm in starting with that properties.
As a result, we just need a model that can be interpreted into infra and we can add less complexity by not using comprehensive definitions (if it's applicable).