-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for modelina in v3 #1043
Conversation
/rtm |
@fmvilas never thought it could be this easy to support something... 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, did you just want to merge without approval?
what about tests adjustment, so we know v3 really works?
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Not trying to merge without approval @derberg. Just leaving it there for when you approve it merges automatically. |
but we should not remove unnecessary test but have an update to the test to make sure v3 works
but that is not how things work with ready to merge. Once you push any small change, it is no longer ready to merge and label is anyway removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to enable AsyncAPI v3 for Modelina you need to switch to the next branch.
This does contain breaking changes for the models, as well as not being fully released more might pop up.
@fmvilas you can bump the version to v3 now, that supports AsyncAPI v3 and is stable ✌️ |
closing in favour of #1155 |
Activate support for v3 in asyncapi generate models 😄