Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for modelina in v3 #1043

Closed
wants to merge 2 commits into from

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Dec 19, 2023

Activate support for v3 in asyncapi generate models 😄

@fmvilas
Copy link
Member Author

fmvilas commented Dec 19, 2023

/rtm

@KhudaDad414
Copy link
Member

@fmvilas never thought it could be this easy to support something... 😆

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, did you just want to merge without approval?

what about tests adjustment, so we know v3 really works?

Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fmvilas
Copy link
Member Author

fmvilas commented Dec 19, 2023

Not trying to merge without approval @derberg. Just leaving it there for when you approve it merges automatically.

@derberg
Copy link
Member

derberg commented Dec 19, 2023

but we should not remove unnecessary test but have an update to the test to make sure v3 works

Not trying to merge without approval @derberg. Just leaving it there for when you approve it merges automatically.

but that is not how things work with ready to merge. Once you push any small change, it is no longer ready to merge and label is anyway removed

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to enable AsyncAPI v3 for Modelina you need to switch to the next branch.

This does contain breaking changes for the models, as well as not being fully released more might pop up.

@jonaslagoni
Copy link
Member

@fmvilas you can bump the version to v3 now, that supports AsyncAPI v3 and is stable ✌️

@derberg
Copy link
Member

derberg commented Feb 12, 2024

closing in favour of #1155

@derberg derberg closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants