Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup codeowners #1220

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Conversation

Amzani
Copy link
Collaborator

@Amzani Amzani commented Mar 11, 2024

Fixes #1287

@Amzani Amzani changed the title chore: Add Amzani as a code owner chore: add Amzani as a code owner Mar 11, 2024
Souvikns
Souvikns previously approved these changes Mar 11, 2024
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Amzani, welcome aboard! 🎉 🎉 🎉

@derberg
Copy link
Member

derberg commented Mar 11, 2024

@Amzani please have a look at #668 (comment)

Can you demonstrate that you did some of this and therefore you understand the project you want to maintain?

@aeworxet
Copy link
Contributor

@fmvilas trusted @Amzani to look over a Bounty Issue
asyncapi/studio#755 (comment)
he translated design part of CLI into a technical task
#1214
and he is an active maintainer of Studio
https://github.com/asyncapi/studio/pulls?q=is%3Apr+author%3AAmzani

@derberg
Copy link
Member

derberg commented Mar 11, 2024

@aeworxet thanks for clarification. Yup I'm aware Samir manages Studio. I also had a sync with @Souvikns that we need to onboard someone so I can quit as maintainers, and Samir's name popped up - which is completely fine.

I just want to be fair and transparent and also consistent with message I share already: #668 (comment)

I also proposed a good onboarding task that will be beneficial for the whole project, and great for maintainer onboarding -> #781 (comment)

@Amzani
Copy link
Collaborator Author

Amzani commented Mar 11, 2024

@derberg makes sense!

(cc @smoya / @Barbanio - this might be also useful for you as you are designing the Maintainer mentorship program)

@derberg
Copy link
Member

derberg commented Mar 21, 2024

@Amzani I would close it, unless you are fine to update it to reflect #1287 but of course once we have all voices there and agreement

@Amzani
Copy link
Collaborator Author

Amzani commented Mar 22, 2024

Sure @derberg I can update this one then and wait for @magicmatatjahu

@Amzani Amzani changed the title chore: add Amzani as a code owner chore: Cleanup codeowners Mar 22, 2024
@Amzani Amzani changed the title chore: Cleanup codeowners chore: cleanup codeowners Mar 22, 2024
@Amzani
Copy link
Collaborator Author

Amzani commented Mar 22, 2024

I left @magicmatatjahu for now until he is back from holidays, @derberg feel free to merge it or wait.

CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amzani @Shurtu-gal you are now invited to repo

please do not forget to followup/triage together with @Souvikns what is already opened in the repo

@magicmatatjahu and me are removed from repo.

good luck!!!

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member

derberg commented Apr 24, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit b9c5dd4 into asyncapi:master Apr 24, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup codeowners
5 participants