Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update @smoya/multi-parser and @asyncapi/parser to include parser v3.0.12 #1338

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

smoya
Copy link
Member

@smoya smoya commented Apr 3, 2024

No description provided.

@smoya smoya changed the title fix: update @smoya/multi-parser to v5.0.5 fix: update @smoya/multi-parser and @asyncapi/parser to include parser v3.0.12 Apr 3, 2024
@smoya
Copy link
Member Author

smoya commented Apr 3, 2024

@Souvikns @derberg @magicmatatjahu this PR is fixing your recent errors in CI failing with:

Error: src/base.ts(46,43): error TS2345: Argument of type 'AsyncAPIDocumentInterface' is not assignable to parameter of type 'AsyncAPIDocument'.

Example: https://github.com/asyncapi/cli/actions/runs/8543665709/job/23408013867?pr=1324

The issue is that multiparser uses parser, and CLI has both parser and multiparser as dependency (which could be removed in favor of multiparser only). So there was a version missmatch between those parsers.

BTW, CI is failing due to a known random error on Windows about the cache. Tried by rerunning (pushed a new empty commit) but still persists

@smoya
Copy link
Member Author

smoya commented Apr 4, 2024

error-windows-gif
Shall we just skip that and merge this by using Maintainer's force?

@derberg
Copy link
Member

derberg commented Apr 9, 2024

did some fixes in CI

updating the branch and lets 🤞🏼

Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member

derberg commented Apr 9, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 2685ff0 into asyncapi:master Apr 9, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants