-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix assets generation on windows machines #1358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Maintainers, as mentioned in the issue, I tried fixing the caching issue on Windows machines by conditionally checking the Link to the workflow: https://github.com/helios2003/cli/actions/runs/8624914219/job/23640659229?pr=1 |
I think it is fixed @helios2003 with #1340 |
Hi @Souvikns, thanks for the quick reply. I tried running the earlier workflow and apparently, it doesn't pass the same subprocess and also it fails the macOS workflow. |
Yeah, I saw this in other PRs as well, does not look like it is occurring due to cache though. |
Oh okay, so can I try to fix the errors in this https://github.com/helios2003/cli/actions/runs/8626561222/job/23644917594?pr=2 |
@helios2003 it is not caching it is because one script is still not modified to support windows just revert your change and update https://github.com/asyncapi/cli/blob/master/package.json#L143 script from
|
Quality Gate passedIssues Measures |
Done!! |
/rtm |
🎉 This PR is included in version 1.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
The build process passes the entire
Test NodeJS PR
pipeline.Related issue(s)
Fixes #1349