Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix assets generation on windows machines #1358

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

helios2003
Copy link
Contributor

Description
The build process passes the entire Test NodeJS PR pipeline.

Related issue(s)

Fixes #1349

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@helios2003
Copy link
Contributor Author

Maintainers, as mentioned in the issue, I tried fixing the caching issue on Windows machines by conditionally checking the npm cache. But a certain substep is failing which passes on other machines. It would be great if someone could point me in the right direction about what is going wrong.

Fix till now:
image

Failed subprocess
image

Link to the workflow: https://github.com/helios2003/cli/actions/runs/8624914219/job/23640659229?pr=1

@Souvikns
Copy link
Member

I think it is fixed @helios2003 with #1340

@helios2003
Copy link
Contributor Author

helios2003 commented Apr 10, 2024

Hi @Souvikns, thanks for the quick reply. I tried running the earlier workflow and apparently, it doesn't pass the same subprocess and also it fails the macOS workflow.
Link: https://github.com/helios2003/cli/actions/runs/8626561222/job/23644917594?pr=2

@Souvikns
Copy link
Member

Hi @Souvikns, thanks for the quick reply. I tried running the earlier workflow and apparently, it doesn't pass the same subprocess and also it fails the macOS workflow. Link: https://github.com/helios2003/cli/actions/runs/8626561222/job/23644917594?pr=2

Yeah, I saw this in other PRs as well, does not look like it is occurring due to cache though.

@helios2003
Copy link
Contributor Author

Oh okay, so can I try to fix the errors in this https://github.com/helios2003/cli/actions/runs/8626561222/job/23644917594?pr=2

@derberg
Copy link
Member

derberg commented Apr 10, 2024

@helios2003 it is not caching

it is because one script is still not modified to support windows

just revert your change and update https://github.com/asyncapi/cli/blob/master/package.json#L143 script from printf command to below node script

node -e \"const fs = require('fs'); fs.writeFileSync('scripts/README.md', '# Usage\\n\\n<!-- usage -->\\n\\n# Commands\\n\\n<!-- commands -->\\n');\"

Copy link

sonarcloud bot commented Apr 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@helios2003 helios2003 marked this pull request as ready for review April 10, 2024 20:14
@helios2003
Copy link
Contributor Author

@helios2003 it is not caching

it is because one script is still not modified to support windows

just revert your change and update https://github.com/asyncapi/cli/blob/master/package.json#L143 script from printf command to below node script

node -e \"const fs = require('fs'); fs.writeFileSync('scripts/README.md', '# Usage\\n\\n<!-- usage -->\\n\\n# Commands\\n\\n<!-- commands -->\\n');\"

Done!!

@derberg derberg changed the title fix: fixing caching on windows machines ci: fix assets generation on windows machines Apr 11, 2024
@derberg
Copy link
Member

derberg commented Apr 11, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 0676c47 into asyncapi:master Apr 11, 2024
23 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Release pipeline is blocked by the windows cache issue
4 participants