Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change .asyncapi-analytics file's directory #1370

Merged

Conversation

peter-rr
Copy link
Member

This PR will change the analytics config file's directory from "current working directory" to "user's home directory" to avoid inconsistencies and unnecessary duplications. See more reasons here.

cc @fmvilas

Copy link
Collaborator

@Amzani Amzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@peter-rr
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 210c40d into asyncapi:master Apr 22, 2024
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@peter-rr peter-rr deleted the fix/analytics-config-file-directory branch May 17, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants