Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update npm to latest for windows #1553

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

Souvikns
Copy link
Member

Description
There was a issue with windows, release as it needed nodejs v20+ to generate assets. https://github.com/asyncapi/cli/actions/runs/11427592031/job/31791892874. In this PR I am updating the workflow to use latest npm version.

Copy link

sonarcloud bot commented Oct 22, 2024

@Souvikns Souvikns marked this pull request as ready for review October 22, 2024 03:55
@Souvikns
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit bc97227 into asyncapi:master Oct 22, 2024
42 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Souvikns added a commit to Souvikns/cli that referenced this pull request Oct 22, 2024
* chore: update package-lock.json

* fix: add package-lock.json (asyncapi#1542)

* chore: migrate github-action to cli (asyncapi#1487)

* New Github action added for cli

* Added new files in the github-action

* removed monorepo style for github action

* Updated github action with Dockerfile changes

* added command to pack cli for linux, docker build command

* added test-workflow for github-action

* chore: fix docker context

* chore: change docker context

* fix: dockerfile

* changed dockerfile

* fix: dockerfile

* Converted Dockerfile into multi stages

* added github-action folder

* added assets folder to github action image

* deleted act file script

* removed asyncapi.yaml file from .gitignore

* corrected output file for workflow

* updated Dockerfile

* added bundle file

* changed bundle files

* Updated README

* updated output bundle directory

---------

Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: Ashish Padhy <[email protected]>

* feat: update oclif to v4 (asyncapi#1546)

* feat: update oclif to v4

* chore: removed unused dependencies

* Update myhook.ts

* chore: update package-lock.json version (asyncapi#1550)

* fix: add description for the start command in AsyncAPI CLI (asyncapi#1534) (asyncapi#1537)


Co-authored-by: Ashish Padhy <[email protected]>

* chore(release): v2.7.1 (asyncapi#1551)

* fix: update npm to latest for windows (asyncapi#1553)

* chore(release): v2.7.2 (asyncapi#1554)

* Update upload-release-assets.yml

---------

Co-authored-by: root <root@LAPTOP-K7PL9FIU>
Co-authored-by: Ashish Padhy <[email protected]>
Co-authored-by: Akshat Nema <[email protected]>
Co-authored-by: asyncapi-bot <[email protected]>
Co-authored-by: Taufiq Hassan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants