feat: generate example function for TypeScript models #568
Conversation
chinma-yyy
requested review from
Souvikns,
magicmatatjahu,
derberg,
boyney123 and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
chinma-yyy
changed the title
chinma-yyy
changed the title
|
There is a problem in the code formatting and I don't know how to resolve it. Please if anyone can help me with it. |
|
Kudos, SonarCloud Quality Gate passed!
|
| presets.push({ | ||
| preset: TS_COMMON_PRESET, | ||
| options: { | ||
| marshalling: true | ||
| } | ||
| }, |
There was a problem hiding this comment.
Do you see that the same preset are added twice now, just with slightly different options? 🙂
This should not be the case, it can only be added once, and then the options should change slightly based on the parameters 🙂
There was a problem hiding this comment.
It is not getting added twice even if there are both flags in the command of tsExampleInstance and tsJsonBinPack. I think Modelina has the support for this where the same preset is added with multiple values of options then it gets combined to give the output. Just the order of the functions generated is getting changed somewhat rest is the same for me.
There was a problem hiding this comment.
Another approach would be to create an object variable
const options={
example : tsExampleInstace ,
marshalling : tsMarshalling
}
presets.push({
preset: TS_COMMON_PRESET,
options:options
})and then use this while pushing the presets which can also resolve #460
There was a problem hiding this comment.
Ahh you right, it's allowed as long as the options don't overlap or default behavior adds some stuff. Because otherwise it will be added twice 😄
Description
tsExampleInstancewhich if true adds an example of the model generated .Related issue(s)
Resolves #462