feat: add Dockerfile and its release pipeline #598
Conversation
Savio629
requested review from
Souvikns,
magicmatatjahu,
derberg,
boyney123 and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
derberg
changed the title
|
@Savio629 so far so good, just solve merge conflicts are you still exploring alternative solution? I was also wondering if you could add https://github.com/marketplace/actions/docker-hub-readme-description-sync as another step in the automation, after pushing to docker? as apparently docker do not pick github readme by default |
|
I'm exploring the alternative solution, I'll update you by tomorrow. |
derberg
changed the title
|
@Savio629 yup, all good with workflows, you can remove |
Co-authored-by: Lukasz Gornicki <[email protected]>
|
@Savio629 can you also have a look on sonarcloud complain about security? |
|
@derberg Fixed one of the warnings but the second warning tells me to run the dockerfile in |
|
@Savio629 but sonar said to use |
|
Yeah I updated the pr. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm Thanks 🙏 |
|
🎉 This PR is included in version 0.47.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| docker push asyncapi/cli:${{ steps.version.outputs.value }} | ||
| docker push asyncapi/cli:latest | ||
|
|
||
| - name : Sync README.md and Description to Docker Hub |
There was a problem hiding this comment.
Does it really need a secund checkout action?
| rm /var/cache/apk/* | ||
|
|
||
| # Installing latest released npm package | ||
| RUN npm install --ignore-scripts -g @asyncapi/cli |
There was a problem hiding this comment.
I think the cli version should be configurable, because then you don't know which version is inside the container
| # Switch to the non-root user | ||
| USER myuser | ||
|
|
||
| ENTRYPOINT [ "asyncapi" ] |
| @@ -177,4 +178,4 @@ | |||
| "get-version": "echo $npm_package_version" | |||
| }, | |||
| "types": "lib/index.d.ts" | |||
| } | |||
| } | |||
|
@Ferror the PR is already merged, please open up a followup to improve it 🙏🏼 |
Description
Draft PR
-Added Docker using npm (researching using linux-curl)
-Added worflow for docker
-Added docker:build script
Related issue(s)
Resolves #358