Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with bundle command #700

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Conversation

Souvikns
Copy link
Member

@Souvikns Souvikns commented Jul 25, 2023

bundle command was unable to output in json format.

Description

The bundle command was unable to export to .json format as document.json returns an object instead of a string.

await writeFile(path.resolve(process.cwd(), output), document.json(), {

Related issue(s)

Fixes #699

bundle command was unable to output in json format.
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can you update tests?
  • I guess description should say this PR resolves the other issue, so it is closed after merge

@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Souvikns
Copy link
Member Author

@derberg made the changes your requested, ready for review.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Souvikns
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit be6186f into asyncapi:master Jul 26, 2023
11 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.51.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't bundle yaml file with json output file
3 participants