-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue with bundle command #700
Conversation
bundle command was unable to output in json format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can you update tests?
- I guess description should say this PR resolves the other issue, so it is closed after merge
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@derberg made the changes your requested, ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rtm |
🎉 This PR is included in version 0.51.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
bundle command was unable to output in json format.
Description
The
bundle
command was unable to export to.json
format asdocument.json
returns an object instead of a string.cli/src/commands/bundle.ts
Line 60 in a874a1a
Related issue(s)
Fixes #699