Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add instruction how voting automation works #1155
docs: add instruction how voting automation works #1155
Changes from 7 commits
0cc25d9
f71e33a
2190d83
6cee4db
07e443f
fe6c3b0
4afd81c
a6fac7e
95b81aa
1240bd7
4292db2
7bd2ed4
697099b
175319e
82fa0c9
1921519
647d2f7
70de86e
9926395
76991ab
991f34e
f06f6a3
e15ae4a
5e44df1
4f28b95
e3e42c3
b90b6e3
1b7d67b
c625991
07adb63
e2c6600
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to have it - added basing on comment from @smoya about notifying people about voting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derberg
Do we need to send notifications every day [ 28 days ] to the Slack channel as well as mail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smoya @derberg Created an issue to enable notification #1163. @derberg We can update the doc when the above issue is complete, I will work on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this is different
the section I add is about: notify voting in place
we do not have yet: remind those that did not vote, that will probably be another paragraph once we add automation
thanks for creating the issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derberg How we can automate to check whether the person has voted or not in the last 3 Months? I guess we can create one more issue for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes definitely we need automation for it, create issue - yes - please
should not be hard, we run GH query to list all issues and PRs with
vote
label added in last 3 months. Then we parse the voting comment from bot, the voting summary one, and see who did not vote, and do some magic calculation 😄can be also that we do it on schedule. Every month run a query that summarize voting, like you know we maintain some markdown with votes, and list of folks who did not participate - advantage is that we can also "discover" if someone is close to deadline and send a "warning" notification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add suggested section to document?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, as I shared via DM on Slack, please clarify in the doc the following: