Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first iteration of the AACOT'23 website implementation #157

Merged
merged 57 commits into from
Aug 9, 2023

Conversation

AceTheCreator
Copy link
Member

This is the first implementation of the AsyncAPI conference website which includes the following.

  • Index page
  • Venues Page
  • Speakers Component
  • Venue Component
  • The Globe with the pinned event location

cc @thulieblack @Mayaleeeee @derberg @Barbanio @alequetzalli

@Barbanio
Copy link

Barbanio commented Aug 7, 2023

1334x750px (326 ppp)

@AceTheCreator
Copy link
Member Author

1334x750px (326 ppp)

Is it the last preview on the list?

@Barbanio
Copy link

Barbanio commented Aug 7, 2023

Is it the last preview on the list?

Yes

@AceTheCreator
Copy link
Member Author

Is it the last preview on the list?

Yes

Oh! this was because I didn't include an infinity scroll. Fixed!

@Mayaleeeee
Copy link
Member

Pr updated! @thulieblack @Mayaleeeee @derberg
Thank you.

@Mayaleeeee
Copy link
Member

  1. The Madrid button should be active once the users reach the speaker section since that's the first set of speakers they will see.

Screenshot 2023-08-07 160238

  1. The subscribe button here takes me to another page: "Subscribe to our newsletter to receive news about AsyncAPI." Is that intentional?

Screenshot 2023-08-07 160401

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Aug 7, 2023

Under this same page, we also mentioned that we should add a section where users will see the event/host sponsors of the location immediately after they enter the page, it's on the design I created (see the picture below), but it's not on the deploy-preview

@Mayaleeeee It doesn't make sense to me why we are gonna have the sponsors there and then still have it in another section of the page. That was why I didn't include it.

The remaining you pointed out(apart from the last one) was all intentional as I also want other contributors to fix this minor issue as a means of contributing to the project

We can reduce the whitespace since we won't add the event/host sponsors here.
Screenshot 2023-08-07 162359

I realized the map on the location page is on the preview website. Was that intentional?
Screenshot 2023-08-07 163039

{
"name": "Bangalore",
"country": "India",
"date": "TBA",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"date": "TBA",
"date": "November 30, 2023",

"date": "TBA",
"description": "Join us in Bangalore for the AsyncAPI Conference and learn more about APIs and EDAs! Let's have a memorable fiesta!",
"img": "https://images.unsplash.com/photo-1596176530529-78163a4f7af2?ixlib=rb-4.0.3&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D&auto=format&fit=crop&w=2454&q=80",
"address": "309, Venkatesh complex, floor, 100 feet road, Indiranagar, Bangalore, Karnataka 560038, India"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"address": "309, Venkatesh complex, floor, 100 feet road, Indiranagar, Bangalore, Karnataka 560038, India"
"address": "310, 6th Main Rd, HAL 2nd Stage, Indiranagar, Bengaluru, Karnataka 560038, India"

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Aug 7, 2023

For each of the locations, we could have something like this:

  1. Madrid:
    Join us in Madrid for AsyncAPI Conference and learn how to speak fluent API! Let's taco about messaging and have a fiesta you will remember!

  2. London:
    Join us in London for the AsyncAPI Conference and unlock the API of opportunities! Let's bridge the messaging gap and create a tech buzz you will want to experience!

  3. Paris:
    Join us in Paris for the AsyncAPI Conference and experience the art of API perfection! Let's craft a symphony of messaging and celebrate tech in style!

  4. Bengaluru:
    Join us in Bengaluru for the AsyncAPI Conference and decode the language of APIs! Let's crack the language of APIs and ignite a tech revolution with some spice you'll remember!

The names of the locations will be displayed in bold and in the same colour as the date. This signifies that they are clickable. Users can click on the location name or the accompanying image to access the corresponding page directly. I recommend this approach to avoid confusion caused by the phrase 'Join us,' which begins each location's description.

I'd like more suggestions and would appreciate your input on this approach. @AceTheCreator @thulieblack @derberg @Barbanio

@AceTheCreator
Copy link
Member Author

Under this same page, we also mentioned that we should add a section where users will see the event/host sponsors of the location immediately after they enter the page, it's on the design I created (see the picture below), but it's not on the deploy-preview

@Mayaleeeee It doesn't make sense to me why we are gonna have the sponsors there and then still have it in another section of the page. That was why I didn't include it.
The remaining you pointed out(apart from the last one) was all intentional as I also want other contributors to fix this minor issue as a means of contributing to the project

We can reduce the whitespace since we won't add the event/host sponsors here. Screenshot 2023-08-07 162359

done!

I realized the map on the location page is on the preview website. Was that intentional? Screenshot 2023-08-07 163039

This is also intentional. It will come as a contribution.

@AceTheCreator
Copy link
Member Author

  1. The Madrid button should be active once the users reach the speaker section since that's the first set of speakers they will see.

This is intentional, as suggested by @derberg we should render all speakers by default and then by clicking you filter by region

Screenshot 2023-08-07 160238

  1. The subscribe button here takes me to another page: "Subscribe to our newsletter to receive news about AsyncAPI." Is that intentional?

Yea, this is also intentional as we don't have the bandwidth to maintain a different newsletter for conference

Screenshot 2023-08-07 160401

@Mayaleeeee
Copy link
Member

  1. The Madrid button should be active once the users reach the speaker section since that's the first set of speakers they will see.

This is intentional, as suggested by @derberg we should render all speakers by default and then by clicking you filter by region

Screenshot 2023-08-07 160238

  1. The subscribe button here takes me to another page: "Subscribe to our newsletter to receive news about AsyncAPI." Is that intentional?

Yea, this is also intentional as we don't have the bandwidth to maintain a different newsletter for conference

Screenshot 2023-08-07 160401

We should have a "All" button then.
What do you think?

@thulieblack
Copy link
Member

Hey @Mayaleeeee, the newsletter details are fine as it is. The monthly newsletter shipped out every month will contain all the necessary information about all the conferences

@Mayaleeeee
Copy link
Member

Hey @Mayaleeeee, the newsletter details are fine as it is. The monthly newsletter shipped out every month will contain all the necessary information about all the conferences

Ohh, that's cool then.

@AceTheCreator
Copy link
Member Author

I think this PR is rtm cc @derberg @thulieblack @Mayaleeeee @Barbanio

@derberg
Copy link
Member

derberg commented Aug 8, 2023

lgtm, I personally do not spend much time on websites to be patient enough to wait for entire globe animation, and see how new cities and countdown shows up. I personally would prefer to show all locations and countdowns by default (and they can highlight or whatever one after another if you want). But if I'm the only one and others like how it is now, I won't block.

Great stuff @AceTheCreator 🚀
@Mayaleeeee you've got a pretty nice production implementation of your design for your portfolio, well done 👏🏼

@Mayaleeeee
Copy link
Member

I think this PR is rtm cc @derberg @thulieblack @Mayaleeeee @Barbanio

I apologize, @AceTheCreator, but there seems to be a misunderstanding. I was actually referring to the specific locations marked in the screenshot below and not the main location header.

Screenshot 2023-08-08 135904

@Mayaleeeee
Copy link
Member

lgtm, I personally do not spend much time on websites to be patient enough to wait for entire globe animation, and see how new cities and countdown shows up. I personally would prefer to show all locations and countdowns by default (and they can highlight or whatever one after another if you want). But if I'm the only one and others like how it is now, I won't block.

Great stuff @AceTheCreator 🚀 @Mayaleeeee you've got a pretty nice production implementation of your design for your portfolio, well done 👏🏼

Thank you so much.
Well done @AceTheCreator

@AceTheCreator
Copy link
Member Author

I think this PR is rtm cc @derberg @thulieblack @Mayaleeeee @Barbanio

I apologize, @AceTheCreator, but there seems to be a misunderstanding. I was actually referring to the specific locations marked in the screenshot below and not the main location header.

Screenshot 2023-08-08 135904

Oh! If that's what you meant, then I don't think that will be necessary because making the whole card clickable is the best UX IMHO not the text within a sentence. I'll change the title back to white :)

@Mayaleeeee
Copy link
Member

I think this PR is rtm cc @derberg @thulieblack @Mayaleeeee @Barbanio

I apologize, @AceTheCreator, but there seems to be a misunderstanding. I was actually referring to the specific locations marked in the screenshot below and not the main location header.
Screenshot 2023-08-08 135904

Oh! If that's what you meant, then I don't think that will be necessary because making the whole card clickable is the best UX IMHO not the text within a sentence. I'll change the title back to white :)

Sure, that works as well. My worry was about the main location header, and I can see that you have adjusted the color. Thank you.

Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; let's get the 1st iteration merged!!

@derberg
Copy link
Member

derberg commented Aug 9, 2023

merge merge merge and in a follow up PR I guess it is a right time to add CODEOWNERS

@Mayaleeeee
Copy link
Member

🥳🥳🥳🌸

@AceTheCreator AceTheCreator merged commit a069ab4 into asyncapi:master Aug 9, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants