Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include a map section on each venue page #174

Closed
wants to merge 5 commits into from

Conversation

kabszac
Copy link

@kabszac kabszac commented Aug 24, 2023

Description

Screenshot from 2023-08-24 11-55-28
Screenshot from 2023-08-24 11-55-37

@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit a68b22a
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6515b78c467c5d00080e922f
😎 Deploy Preview https://deploy-preview-174--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kabszac kabszac changed the title Include a map section on each venue page feat: Include a map section on each venue page Aug 24, 2023
@kabszac kabszac changed the title feat: Include a map section on each venue page feat: include a map section on each venue page Aug 24, 2023
@AceTheCreator
Copy link
Member

Looks good! Just a minor suggestion: can you reduce the height of the map a bit?

@kabszac
Copy link
Author

kabszac commented Sep 10, 2023

@AceTheCreator what suggestion would you have the ideal height to be?

@AceTheCreator
Copy link
Member

AceTheCreator commented Sep 18, 2023

@AceTheCreator what suggestion would you have the ideal height to be?

I mean probably half of the current height we have now @kabszac

@kabszac
Copy link
Author

kabszac commented Sep 19, 2023

@AceTheCreator thank you let me make the necessary changes

@AceTheCreator
Copy link
Member

@kabszac any update on this?

@kabszac
Copy link
Author

kabszac commented Sep 23, 2023

@AceTheCreator made the changes

@AceTheCreator
Copy link
Member

@kabszac you have a merge conflict :)

@kabszac
Copy link
Author

kabszac commented Sep 25, 2023

@AceTheCreator resolved the merge conflict

@AceTheCreator
Copy link
Member

@kabszac, I am so sorry about the late review. Can you kindly resolve the following conflict one lat time?

@kabszac
Copy link
Author

kabszac commented Sep 28, 2023

@AceTheCreator resolved

@AceTheCreator
Copy link
Member

@AceTheCreator resolved

I keep getting the following error when previewing the page. 🤔

Application-error-a-client-side-exception-has-occurred

@kabszac
Copy link
Author

kabszac commented Sep 29, 2023

@AceTheCreator let me try opening another pull request on this issue. is it ok?

@AceTheCreator
Copy link
Member

AceTheCreator commented Sep 29, 2023

@AceTheCreator let me try opening another pull request on this issue. is it ok?

Okay 👍🏾

@kabszac kabszac closed this Sep 29, 2023
@kabszac kabszac deleted the mapsection branch September 29, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a map section on each venue page
2 participants