-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: header sizing #177
fix: header sizing #177
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@Mayaleeeee please let me know if any changes are required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Thank you @SoNiC-HeRE
@SoNiC-HeRE can you update the branch with the latest changes from master |
sure |
@AceTheCreator please let me know if any more changes are required |
Noticed the heading size stays the same despite the screen size. I believe is should be smaller on mobile screen size. cc @Mayaleeeee |
Yeah, I just noticed that too, thanks @AceTheCreator @SoNiC-HeRE, please use 32px for the text, 38px for line height and -2% for letter spacing for the header size on mobile. |
@AceTheCreator @Mayaleeeee let me know if more changes are required |
LGTM! @Mayaleeeee wyt? |
Awesome 🤗🤗 |
Description
Made the font bold, increased text-size, line-height and letter-spacing
Used available classes rather than going for custom css class
Before:
Applying custom-class as provided here
Change the font size used for the header on the Conference Website. #175 (comment)
Applying Pre-Defined Class (Current):
Decided to stick with the last layout as it appears more clean but if required, I'd change it as suggested
Related issue(s)
Fixes #175