-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add all speakers button #192
feat: add all speakers button #192
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Nicely done @Sylvie-Wxr Just a few changes are needed.
|
Hey @AceTheCreator , i have fixed the spacing. |
Hey @AceTheCreator, should we do the following in a separate issue/PR and merge this first?
|
@Sylvie-Wxr you can do it on the same PR |
Hi @AceTheCreator , is this the color you meant? |
@Sylvie-Wxr, what I mean is the Button itself should be colored :) |
@AceTheCreator Like this? |
Yea @Sylvie-Wxr Also you should also include color on the border :) |
Hi @AceTheCreator I have removed the border. If there are no other changes required, can we merge this PR? |
LGTM!!! |
Add all speakers button
solves #163