Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update get free tickets button #207

Closed
wants to merge 4 commits into from

Conversation

SoNiC-HeRE
Copy link
Contributor

Description

Before:
image

After:
Screenshot from 2023-09-30 09-56-00

Related issue(s)
Fixes #198

@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 57a8b89
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/651af326125aa50008cc1c3b
😎 Deploy Preview https://deploy-preview-207--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoNiC-HeRE SoNiC-HeRE changed the title fix: Update Get Free Tickets Button fix: Update Get Free Tickets Button Sep 30, 2023
@SoNiC-HeRE SoNiC-HeRE changed the title fix: Update Get Free Tickets Button fix: update get free tickets button Sep 30, 2023
@Mayaleeeee
Copy link
Member

Mayaleeeee commented Sep 30, 2023

Thank you, @SoNiC-HeRE for your effort! To ensure consistency with our other pages, let's use 'Free Tickets for Madrid' in a horizontal layout, without placing 'Madrid' beneath 'Get Free Tickets for Madrid.'

cc @derberg @AceTheCreator @thulieblack

@SoNiC-HeRE
Copy link
Contributor Author

Thank you, @SoNiC-HeRE for your effort! To ensure consistency with our other pages, let's use 'Free Tickets for Madrid' in a horizontal layout, without placing 'Madrid' beneath 'Get Free Tickets for Madrid.'

cc @derberg @AceTheCreator @thulieblack

Sure I'll change it,I was following what was mentioned here #198

@SoNiC-HeRE
Copy link
Contributor Author

image

@SoNiC-HeRE
Copy link
Contributor Author

@Mayaleeeee please let me know if further changes are required

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Oct 1, 2023

@Mayaleeeee please let me know if further changes are required

We don't need to add a colon, just this 👇👇👇

Free Tickets for Madrid

@SoNiC-HeRE

@SoNiC-HeRE
Copy link
Contributor Author

SoNiC-HeRE commented Oct 1, 2023

image

@Mayaleeeee

@Mayaleeeee
Copy link
Member

image

@Mayaleeeee

Remove the ''Get''

''Free Tickets For Madrid" is fine.

@SoNiC-HeRE
Copy link
Contributor Author

SoNiC-HeRE commented Oct 2, 2023

image
@Mayaleeeee

Remove the ''Get''

''Free Tickets For Madrid" is fine.

I've applied the changes, let me know if anything else needs to be done

image

@Mayaleeeee
Copy link
Member

image
@Mayaleeeee

Remove the ''Get''

''Free Tickets For Madrid" is fine.

I've applied the changes, let me know if anything else needs to be done

image

Awesome 🎉🎉
Thank you @SoNiC-HeRE

@AceTheCreator
Copy link
Member

@SoNiC-HeRE update the Madrid ticket link to this https://www.eventbrite.es/e/entradas-asyncapi-conf-on-tour-2023-735378636297 and resolve the conflicts in your PR and we are good to go :)

@SoNiC-HeRE
Copy link
Contributor Author

SoNiC-HeRE commented Oct 15, 2023

@SoNiC-HeRE update the Madrid ticket link to this https://www.eventbrite.es/e/entradas-asyncapi-conf-on-tour-2023-735378636297 and resolve the conflicts in your PR and we are good to go :)

Sure, I'll get this fixed

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 13, 2024
@AceTheCreator
Copy link
Member

Sorry, I have to close this PR as the enhancement is not needed anymore due to an updated version of the website :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Get Free Tickets on main page to link to proper google form
3 participants