Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the venue sub menu not closing #248

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

ShashwatPS
Copy link
Contributor

Description :
Fixed the part where the venue sub menu on the navbar was not closing when clicked anywhere but inside the menu.

Related issue(s) :

Resolves #205

Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit c3c5b06
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/655dd5da1e6b88000823daba
😎 Deploy Preview https://deploy-preview-248--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@ShashwatPS
Copy link
Contributor Author

@AceTheCreator Could you please review the pull request I've submitted?

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you some review

components/Navbar/navbar.js Outdated Show resolved Hide resolved
components/Navbar/navbar.js Outdated Show resolved Hide resolved
components/Navbar/navbar.js Outdated Show resolved Hide resolved
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left you some comments

Copy link
Contributor Author

@ShashwatPS ShashwatPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with the changes.

@AceTheCreator
Copy link
Member

Well done @ShashwatPS

@AceTheCreator AceTheCreator merged commit aa0a693 into asyncapi:master Nov 22, 2023
12 checks passed
@RamGoel RamGoel mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Venue sub menu doesn't close
2 participants