-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: past editions module #260
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
The |
This is coming together nicely. @Mayaleeeee @AceTheCreator thoughts on the Past Editions Page? |
Thank you for mentioning me, @thulieblack. And @RamGoel, I appreciate the work you've done on this issue. Regarding issue #211, @Thehussayn has already created a low-fidelity design that relates somewhat to this issue. I'll review it soon and see how we can incorporate both designs. @RamGoel, we'll remove the pagination dots under the " Speaker's " section from the design above and replace them with "View All Speakers." However, we'll keep the animation intact. Also, please change 'Past editions' to 'Past Editions' and replace 2023 with AACoT'23 in the dropdown. Finally, I will re-review the design and the #211 issue to figure out how to make it work. |
ah I see, alright @Mayaleeeee, kindly review the #211 PR, and @RamGoel you can also have a look at the proposed design and see if you can incorporate them or improve from what we have |
Hi both of you, a lil busy these days at work. will possibly try to fix them by next week. |
Hi @RamGoel |
Hi @Mayaleeeee Just give me time of today. I'll push the requested changes. |
Hi @Mayaleeeee A new page will open of click of |
Hi @Mayaleeeee can you help with this? |
I'll definitky take a look at when once I'm on my desktop 🙏 |
Hi @Mayaleeeee , are you back on desk? |
Thanks @RamGoel. I have reviewed it, but you still need to make the changes we discussed here. |
Or is there a new update you'd like me to check? |
I wanted your opinion on this. |
Oh, great! Let's have a new page when users click on 'View All Speakers' for the 2023 conference. |
@Mayaleeeee I have implemented the new page for speakers inside the editions route, url goes like this The design of the editions page also has been updated after merging changes that @AceTheCreator made in #263 . You can check this for latest preview |
Sorry for jumping in late to the discussion. But this won't be necessary anymore, @RamGoel, since all the conference pages are archived. What you can work on now is to create a new page on the current website, "Past Editions," and add the previous conference websites. here are the links to each: |
Okay @thulieblack , got your point. Would you like me to add a dropdown on past editions for all years or cards for all years on a new page? |
Cards seem interesting. Lets see what you come up with 😉 |
I agree as well. Let's see how it turns out. |
@thulieblack @Mayaleeeee raised a new PR #265 |
Description
This PR implements the past editions module for 2023 edition of conference.(as of now)
Whatever the events get added to
cities-list.json
. It will automatically create pages out of it.bandicam-2024-01-24-21-23-51-937_SoiQyhH9.mp4
Related Issues
Fixes some part of #259