Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: existing lint issues #337

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

kavania2002
Copy link
Contributor

Description

  • Changed from <img> to <Image> (used computed values for width/height if not given)
  • Added dependencies in useEffect function

Related issue(s)
Fixes #328

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 310cdc0
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6672cd300e72b90008c795f4
😎 Deploy Preview https://deploy-preview-337--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashmit-coder
Copy link
Contributor

Hey @kavania2002 please look into this Screenshot_20240614_232314_Chrome.jpg

Screenshot_20240614_232306_Chrome.jpg

Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thulieblack
Copy link
Member

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator @thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋

@AceTheCreator
Copy link
Member

@kavania2002 can you resolve the merge conflict?

@kavania2002
Copy link
Contributor Author

@kavania2002 can you resolve the merge conflict?

I have resolved the merge conflicts. Do have a look @AceTheCreator

@AceTheCreator AceTheCreator merged commit f9f8673 into asyncapi:master Jun 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Resolve the existing Next.js lint issues
5 participants