fix: ticket section is being rendered #398
Conversation
Aryan4884
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aryan4884
changed the title
Aryan4884
changed the title
|
Changed the issue name |
Aryan4884
changed the title
|
Hey @AceTheCreator is this what is expected from the issue? |
|
Hey @AceTheCreator I feel like this design change looks way too elongated and kinda makes a bit of clutter, what do you think? cc: @Aryan4884 |
What would you suggest @ashmit-coder? |
I liked the ended on coming data being mentioned in the button of the card. It is some other pr but it was closed for some reason? |
There was a problem hiding this comment.
@Aryan4884 we shouldn't have two ticket sections. All tickets should be rendered in the same section. upcoming event should come first
|
Also resolve the conflicts in your PR |
|
@AceTheCreator |
|
Hey @Aryan4884 the hover animation looks like its overlapping other tickets, either increase the spacing within them or change th e opacity on hover. |
#395 Issue:- This PR addresses the issue of displaying past events in the ticket section, providing users with a full history of available tickets for better transparency and context.
Changes Made:
TicketCards Component:
Adjusted the cardOpacity logic to ensure past events (ended === true) are still displayed with lower opacity.
Modified button text and styles to indicate if an event has ended or is upcoming.
Home Component:
Updated the ticket section to display both ended and upcoming events by removing the condition if(city.ended === false).
Ensured all events are listed in the ticket section, regardless of whether they have ended.
Preview:
Users can now see both upcoming and past events in the ticket section, allowing them to explore the full history of events and their respective ticket statuses.
Manually tested the ticket section to confirm that all events, both ended and upcoming, are displayed correctly.
