Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: speakers images #400

Merged
merged 26 commits into from
Oct 23, 2024
Merged

fix: speakers images #400

merged 26 commits into from
Oct 23, 2024

Conversation

Aryan4884
Copy link
Contributor

@Aryan4884 Aryan4884 commented Oct 1, 2024

#396
This PR resolves that issue by downloading and storing the speaker images locally. This change ensures that the speaker images are always available, thereby improving the overall reliability and consistency of the website.

Changes Made:
Speaker Images Storage:
Downloaded all speaker images from external URLs and stored them in the /public/img/speakers/ directory.
Updated the speaker image paths to reference the local files instead of external URLs.
Speaker Component:
Updated the image src in the Speaker component to use the new local paths.
Benefits:
Reliability: The images are no longer dependent on external URLs, preventing broken image issues caused by changes in external sources.
Performance: Local images reduce latency and improve load time, since they are served directly from our server.
Maintenance: Easier management of speaker images, as they are all stored and versioned within the project.
Screenshot 2024-10-01 175046

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 5dbc1e2
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6718bd8f70d4330008abb5d1
😎 Deploy Preview https://deploy-preview-400--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Aryan4884
Copy link
Contributor Author

Please ignore multiple commit as I have forgotten to make a different branch for this separate issue, thatswhy my previous commit which was for different issue are also getting shown.

@ashmit-coder
Copy link
Contributor

Hey @Aryan4884 please follow the pr naming conventions as mentioned by the asyncapi-bot above.

@Aryan4884 Aryan4884 changed the title Made all speakers images available locally Speakers images Oct 1, 2024
@Aryan4884 Aryan4884 changed the title Speakers images fix: speakers images Oct 1, 2024
@Aryan4884
Copy link
Contributor Author

Is it ok now?

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aryan4884 can you store all images in a .webp format?

@Aryan4884
Copy link
Contributor Author

@AceTheCreator changed the format to .webp

@ashmit-coder
Copy link
Contributor

ashmit-coder commented Oct 7, 2024

@Aryan4884 there is some error, please resolve it. In my opinion its arising from the conference-website submodule in your PR.

@Aryan4884
Copy link
Contributor Author

Aryan4884 commented Oct 7, 2024

@ashmit-coder By mistake i messed up the file directories and submodules.
But now its fine.

@ashmit-coder
Copy link
Contributor

@Aryan4884 please resolve the merge conflicts.

@Aryan4884
Copy link
Contributor Author

@ashmit-coder done

Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AceTheCreator
Copy link
Member

@Aryan4884, kindly resolve the conflict in this PR. we should be good to go once that's fixed 👍🏾

@Aryan4884
Copy link
Contributor Author

@AceTheCreator done

@ashmit-coder
Copy link
Contributor

LGTM! @AceTheCreator

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

package.json Outdated Show resolved Hide resolved
@AceTheCreator
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit a3fec5f into asyncapi:master Oct 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants