-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: speakers images #400
fix: speakers images #400
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Please ignore multiple commit as I have forgotten to make a different branch for this separate issue, thatswhy my previous commit which was for different issue are also getting shown. |
Hey @Aryan4884 please follow the pr naming conventions as mentioned by the |
Is it ok now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aryan4884 can you store all images in a .webp format?
@AceTheCreator changed the format to .webp |
@Aryan4884 there is some error, please resolve it. In my opinion its arising from the |
…ce-website into second_commit
@ashmit-coder By mistake i messed up the file directories and submodules. |
@Aryan4884 please resolve the merge conflicts. |
@ashmit-coder done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @AceTheCreator
@Aryan4884, kindly resolve the conflict in this PR. we should be good to go once that's fixed 👍🏾 |
@AceTheCreator done |
LGTM! @AceTheCreator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/rtm |
#396
This PR resolves that issue by downloading and storing the speaker images locally. This change ensures that the speaker images are always available, thereby improving the overall reliability and consistency of the website.
Changes Made:
Speaker Images Storage:
Downloaded all speaker images from external URLs and stored them in the /public/img/speakers/ directory.
Updated the speaker image paths to reference the local files instead of external URLs.
Speaker Component:
Updated the image src in the Speaker component to use the new local paths.
Benefits:
Reliability: The images are no longer dependent on external URLs, preventing broken image issues caused by changes in external sources.
Performance: Local images reduce latency and improve load time, since they are served directly from our server.
Maintenance: Easier management of speaker images, as they are all stored and versioned within the project.