Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: open links in new tab of 'Resources Hub' section #437

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: open links in new tab of 'Resources Hub' section #437

wants to merge 7 commits into from

Conversation

toffee-k21
Copy link
Contributor

Description

@netlify Netlify
Copy link

netlify bot commented Oct 23, 2024 •
edited
Loading

✅ Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3b59a37
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6722643b90b5dc0008c03114
😎 Deploy Preview https://deploy-preview-437--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ashmit-coder
ashmit-coder approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ashmit-coder ashmit-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

AceTheCreator
AceTheCreator requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick one, i think you should pair the target with these rel attribute rel="noopener noreferrer" to avoid security risk

@toffee-k21
Copy link
Contributor Author

Quick one, i think you should pair the target with these rel attribute rel="noopener noreferrer" to avoid security risk

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AceTheCreator AceTheCreator AceTheCreator requested changes

@ashmit-coder ashmit-coder ashmit-coder approved these changes

@thulieblack thulieblack Awaiting requested review from thulieblack thulieblack is a code owner

@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee Mayaleeeee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links in the Resources Hub Should Open in a New Window
3 participants
@toffee-k21 @AceTheCreator @ashmit-coder