feat: remove messageId when converting to 3.0.0

[fmvilas]

Description

Removes the messageId property from the Message objects.

Related issue(s)
asyncapi/spec#978

[github-actions]

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[smoya]

Shall we add a warning or similar mentioning messageId will be "lost" and recommend changing the key of the map to the value messageId had?

[fmvilas]

changing the key of the map to the value messageId had

@smoya isn't it what's already happening? 🤔 I mean, before we used to have oneOf with an array. Now this oneOf is replaced with an object where the keys are the message ids, and we're applying the messageId value when it exists.

[derberg]

This PR only removes messageId when it is no longer needed, but still, if id is present, it is used as a key for a message in v3. So lgtm

[smoya]

changing the key of the map to the value messageId had

@smoya isn't it what's already happening? 🤔 I mean, before we used to have oneOf with an array. Now this oneOf is replaced with an object where the keys are the message ids, and we're applying the messageId value when it exists.

Oh yeah, by removing the messageId the right ID will be picked up 👍 gotcha

[smoya]

LGTM!

[fmvilas]

/rtm

[asyncapi-bot]

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀