Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update the readme path in the docker ci #1246

Merged
merged 32 commits into from
Aug 3, 2024
Merged

chore: update the readme path in the docker ci #1246

merged 32 commits into from
Aug 3, 2024

Conversation

ayushnau
Copy link
Contributor

@ayushnau ayushnau commented Aug 2, 2024 •
edited
Loading

Changes Added.

  1. updated the readme.md path in the docker release ci.
  2. Added the git checkout action in the docker ci.

Related issue(s)

Related to: #1044

ayushnau and others added 28 commits July 29, 2024 20:05
@ayushnau
fix: remove package name from version tag for Docker tagging
84a74e2
@ayushnau
fix: remove the "
c0ae0c0
@derberg
Update breezy-falcons-hammer.md
75b6be9
@ayushnau
Merge pull request #1 from asyncapi/master
dff8fb4 
this is the pr
@ayushnau
update: release.docker.yml file.
f5885e8
@ayushnau
delete unwanted changeset.
760c047
@ayushnau
updated the of nunjuks filter dependency import
4d92a96
@ayushnau
Merge branch 'master' of github.com:asyncapi/generator
42a6693
@ayushnau
Added the changeset .
0415531
@ayushnau
updated the package.lock.json.
a9240d1
@ayushnau
removed the ignore dependency.
eb59676
@ayushnau
Merge branch 'master' of github.com:asyncapi/generator
a7bbc93
@ayushnau
Merge branch 'master' of github.com:asyncapi/generator
ad52f70
@ayushnau
Added the correct path for the readme file.
7f1d9a3
@ayushnau
Update five-boats-prove.md
d1f1c2c
@derberg
Delete .changeset/five-boats-prove.md
49d4dd1
@derberg
Merge branch 'master' into master
8d6abe6
@ayushnau
Added the README.md file for the generator.
1978d50
@ayushnau
Merge branch 'master' of github.com:ayushnau/generator
bde4689
@ayushnau
Added the changeset.
57183fa
@ayushnau
updated the readme for generator.
d4fd48d
@ayushnau
chore: removed the chagneset
23a1ac3
@derberg
Update README.md
ce806fc
@derberg
Merge branch 'master' into master
761be0e
@ayushnau
Merge branch 'master' of github.com:asyncapi/generator
7d183a7
@ayushnau
chore: added the checkout action for the release.
c91f176
@ayushnau
Merge pull request #2 from asyncapi/master
025f41a 
merge.
@ayushnau
Merge branch 'master' of github.com:ayushnau/generator
98b8acf
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e0ed038

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ayushnau ayushnau changed the title testing fix: updated the readme path in the docker ci. Aug 2, 2024
@derberg derberg changed the title fix: updated the readme path in the docker ci. chore: update the readme path in the docker ci Aug 2, 2024
derberg
derberg reviewed Aug 2, 2024
View reviewed changes
.github/workflows/release-docker.yml Outdated
@@ -10,6 +10,9 @@ jobs:
name: Docker build and push
runs-on: ubuntu-latest
steps:
- name: Check out the repository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure it runs only before the step related to readme and use the latest checkout action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done please check.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now you do checkout twice, and still with old version of the action

@ayushnau ayushnau requested a review from derberg August 3, 2024 11:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member

derberg commented Aug 3, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit e814283 into asyncapi:master Aug 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushnau @derberg @asyncapi-bot