Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overall structure and reliability of the function #1296

Closed

Conversation

thebedigupta
Copy link
Contributor

… the last commit

Description
In this PR I worked on that issue

Captured test results test-results.md

Resolve

  • Fixes the potential unhandled promise rejection issue.
  • Maintains the existing error handling within the file walking process.
  • Keeps the overall structure and flow of the function similar to the original

Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: e5c1fc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thebedigupta thebedigupta changed the title Removed the async keyword from the Promise executor function and undo… fix: overall structure and reliability of the function Oct 10, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exists is an async function, why now the whole registerLocalHools is sync? how is this fixing sonar clound issue

Copy link

sonarcloud bot commented Oct 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants