-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update template-development.md #933
Conversation
Fix "supportedProtocols" example + Restate the "template" folder explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Kudos, SonarCloud Quality Gate passed! |
Hi @nickshoe. Thank you for helping make the Generator documentation better. What issue is this PR addressing? |
Hi @Florence-Njeri there is not a tracked issue, the PR addresses a problem in the package.json example and (hopefully) clarifies the purpouse of the template folder and its content. |
Hey @Florence-Njeri, let me know if I shall change something or create an issue for this PR. ;) |
@Florence-Njeri fyi we do not make it mandatory for people to create issue first if the PR has a small scope. In this case of |
Makes sense |
@Florence-Njeri can you have a look? |
@Florence-Njeri @pratik2315 folks we need your approval to merge |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/rtm |
🎉 This PR is included in version 1.10.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description