Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: follow generator v2 that drops node support prior v18 #615

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

derberg
Copy link
Member

@derberg derberg commented Apr 24, 2024

BREAKING CHANGE

Now html-template supports only latest AsyncAPI Generator v2

If you use template version v1 or v2 with AsyncAPI Generator v1

asyncapi generate fromTemplate <asyncapi.yaml> @asyncapi/[email protected]

If you use template version v3 with AsyncAPI Generator v2

asyncapi generate fromTemplate <asyncapi.yaml> @asyncapi/[email protected] --use-new-generator

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@albertodiazdorado
Copy link

Is there anything else preventing this Pull Request from merge?

@peter-rr
Copy link
Member

Is there anything else preventing this Pull Request from merge?

Yeap, first we need to implement a solution to support different versions of generator in the CLI: asyncapi/cli#1388. Once merged, then we can proceed to merge this PR :)

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 13, 2024
@peter-rr
Copy link
Member

Still relevant.

@derberg
I guess this could be merged since asyncapi/cli#1513 has been already released.

Copy link
Member

@peter-rr peter-rr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@derberg derberg marked this pull request as ready for review October 3, 2024 05:05
magicmatatjahu
magicmatatjahu previously approved these changes Oct 7, 2024
Copy link

sonarcloud bot commented Oct 9, 2024

@derberg
Copy link
Member Author

derberg commented Oct 14, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit b933056 into asyncapi:master Oct 14, 2024
10 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants