Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add kaushik-rishi as a code owner #298

Merged
merged 2 commits into from
May 9, 2024

Conversation

kaushik-rishi
Copy link
Collaborator

Description

@kaushik-rishi kaushik-rishi changed the title chore: Add kaushik-rishi as a code owner chore: add kaushik-rishi as a code owner May 8, 2024
@derberg
Copy link
Member

derberg commented May 8, 2024

100% agree as Kaushik demonstrated he know a lot about generator and templates:

  • he delivered a presentation at AsyncAPI on Tour in Bangalore 2024 about templates development
  • he rewrote this template from nunjucks to react - so demonstrated knowledge and understanding of rendering engines
  • he upgraded this template to support asyncapi v3 which means he demonstrated understanding of how asyncapi changed and how new parser API works

so yeah, I'm sure Kaushik will be of a great help as maintainer and will help improve the template even more

@fmvilas any objections?

@fmvilas
Copy link
Member

fmvilas commented May 8, 2024

No objections! He's done some great contributions so that's definitely deserved.

Also, feel free to remove me as code owner as I'm no longer active here.

fmvilas
fmvilas previously approved these changes May 8, 2024
CODEOWNERS Outdated Show resolved Hide resolved
Co-authored-by: Lukasz Gornicki <[email protected]>
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kaushik-rishi
Copy link
Collaborator Author

@derberg updated !

@derberg
Copy link
Member

derberg commented May 9, 2024

@kaushik-rishi welcome mate!!!

I've just sent you an invite to repo

Also, remember that as maintainer, automatically you are allowed to become a TSC member, please have a look at this unofficial onboarding material that explains what it means, duties and benefits -> https://www.youtube.com/watch?v=MfVUUbW2aos

/rtm

@asyncapi-bot asyncapi-bot merged commit b3e9eb8 into asyncapi:master May 9, 2024
10 checks passed
@kaushik-rishi
Copy link
Collaborator Author

@derberg Thanks, this made my day 😄
Accepted the invite.
Will be looking into the TSC onboarding resource shared.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants