Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: release version 1.0.0 of the API #94

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Apr 20, 2023

Description

After #93 got merged, the API seems to be ready for it's first release.
All AsyncAPI V3 changes are in a separate PR: #86, but those can be added later since will not be considered breaking changes.

Note
Pending to check if CI will automatically release it

Related issue(s)
asyncapi/parser-js#585

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smoya
Copy link
Member Author

smoya commented Apr 24, 2023

@derberg Correct me if I’m wrong merging this won’t trigger any kind of release such as creating the GH release, right? No GH action exists for projects without scripting iirc.
Should I need to do it manually, please confirm 🙏 . Thank you!

@smoya
Copy link
Member Author

smoya commented Apr 24, 2023

@derberg Correct me if I’m wrong merging this won’t trigger any kind of release such as creating the GH release, right? No GH action exists for projects without scripting iirc. Should I need to do it manually, please confirm 🙏 . Thank you!

@derberg answered me via Slack (where I also asked) the following:

yeah, all should be good when you merged, and even if GH release is created, why is this a problem?

@smoya
Copy link
Member Author

smoya commented Apr 24, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 652bbe3 into asyncapi:master Apr 24, 2023
@smoya smoya deleted the feat/release branch April 24, 2023 10:16
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants