Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: treat $id as id in schema model and add possibility to pass resolver option to parse and validate function #645

Merged
merged 7 commits into from
Oct 7, 2022

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Oct 6, 2022

Description

  • treat $id as id in schema model.
  • add possibility to pass resolver option to parse and validate function.
  • add missing tags function to the Server model.
  • improve additional* methods in Schema Model

Related issue(s)
Part of #481

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 690cbea into asyncapi:next-major Oct 7, 2022
@magicmatatjahu magicmatatjahu deleted the treat-id-as-id branch October 7, 2022 12:27
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next-major.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants