Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update models with latest parser-api #723

Merged
merged 1 commit into from
Feb 9, 2023
Merged

fix: update models with latest parser-api #723

merged 1 commit into from
Feb 9, 2023

Conversation

magicmatatjahu
Copy link
Member

Description

Update models with latest parser-api:

  • make location in CorrelationId required
  • add missed methods to the OAuthFlow object
  • update Operation and OperationTrait objects
  • add tests

Related issue(s)
See https://github.com/asyncapi/parser-api/blob/master/docs/v1.md
and asyncapi/parser-api#86

@magicmatatjahu magicmatatjahu added the bug Something isn't working label Feb 9, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jonaslagoni
jonaslagoni reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the package-lock change? 🤔

@magicmatatjahu
Copy link
Member Author

@jonaslagoni v1 -> v2 - we have problem because workflows always install deps with npm v6 (with v1 package-lock).

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 4f671a8 into asyncapi:next-major Feb 9, 2023
@magicmatatjahu magicmatatjahu deleted the next/update-parser-api branch February 9, 2023 10:48
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next-major.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready-to-merge released on @next-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmatatjahu @asyncapi-bot @jonaslagoni