chore: merge master into next-major-spec + adapt tests for v3
#824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
smoya
commented
Aug 1, 2023
smoya
commented
smoya
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
smoya
commented
Aug 1, 2023
| const { document, diagnostics } = await parser.parse(documentRaw); | ||
|
|
||
| expect(document).toBeInstanceOf(AsyncAPIDocumentV3); | ||
| expect(diagnostics.length === 0).toEqual(true); // Validation in v3 is still not enabled. This test will intentionally fail once that changes. |
There was a problem hiding this comment.
This is the important change.
smoya
commented
Aug 1, 2023
| { formatVersion: '3.0.10', document: {asyncapi: '3.0.10'}, existsFormat: false, result: false }, | ||
| { formatVersion: '3.0.0', document: {openapi: '3.0.0'}, existsFormat: false, result: false }, | ||
| { formatVersion: '3.0.0', document: null, existsFormat: false, result: false }, | ||
| { formatVersion: '3.0.10', document: {asyncapi: '3.0.10'}, existsFormat: true, result: true }, |
There was a problem hiding this comment.
The format now exists since the schema is found in @asyncapi/specs :)
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.0-next-major-spec.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.