ci: update release workflow #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
princerajpoot20
requested review from
smoya,
BOLT04,
magicmatatjahu and
asyncapi-bot-eve
as code owners
derberg
reviewed
Oct 9, 2023
package.json
Outdated
| @@ -36,8 +36,7 @@ | |||
| "lint:fix": "eslint --max-warnings 0 --config .eslintrc . --fix", | |||
| "generate:assets": "npm run generate:readme:toc", | |||
| "generate:readme:toc": "markdown-toc -i README.md", | |||
| "generate:docker": "docker build --tag asyncapi/server-api .", | |||
| "release": "npm run generate:docker && semantic-release" | |||
| "generate:docker": "docker build --tag asyncapi/server-api ." | |||
There was a problem hiding this comment.
now I noticed that release workflows here are mixed with docker release. There are some additional changes that you need to do, sorry about that
Suggested change
| "generate:docker": "docker build --tag asyncapi/server-api ." | |
| "docker:build": "docker build --tag asyncapi/server-api ." |
you also need to add a new file, called release-docker.yml like below"
name: Release Docker Image
on:
release:
types:
- published
jobs:
publish-docker:
name: Generating Docker
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Get version without v character
id: version
run: |
VERSION=${{github.event.release.tag_name}}
VERSION_WITHOUT_V=${VERSION:1}
echo "value=${VERSION_WITHOUT_V}" >> $GITHUB_OUTPUT
- name: Release to Docker
run: |
echo ${{secrets.DOCKER_PASSWORD}} | docker login -u ${{secrets.DOCKER_USERNAME}} --password-stdin
npm run docker:build
docker tag asyncapi/server-api:latest asyncapi/server-api:${{ steps.version.outputs.value }}
docker push asyncapi/server-api:${{ steps.version.outputs.value }}
docker push asyncapi/server-api:latest
- uses: meeDamian/sync-readme@82715041300710d9be7c726c9d6c683b70451087 #version 1.0.6 https://github.com/meeDamian/sync-readme/releases/tag/v1.0.6
with:
user: ${{secrets.DOCKER_USERNAME}}
pass: ${{ secrets.DOCKER_PASSWORD }}
slug: asyncapi/server-api
description: Server with API that exposes various AsyncAPI tools like AsyncAPI Generator
|
@derberg made the changes 🙂 |
derberg
reviewed
Oct 9, 2023
package.json
Outdated
| @@ -79,9 +78,6 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@semantic-release-plus/docker": "^3.1.0", | |||
There was a problem hiding this comment.
you can remove this too, and refresh package-lock
There was a problem hiding this comment.
@princerajpoot20 have a look please
There was a problem hiding this comment.
@derberg Done 👍 . Sorry for the delay
derberg
reviewed
Oct 11, 2023
package.json
Outdated
| @@ -36,8 +36,7 @@ | |||
| "lint:fix": "eslint --max-warnings 0 --config .eslintrc . --fix", | |||
| "generate:assets": "npm run generate:readme:toc", | |||
| "generate:readme:toc": "markdown-toc -i README.md", | |||
| "generate:docker": "docker build --tag asyncapi/server-api .", | |||
| "release": "npm run generate:docker && semantic-release" | |||
| "docker:build": "docker build --tag asyncapi/server-api ." | |||
There was a problem hiding this comment.
Suggested change
| "docker:build": "docker build --tag asyncapi/server-api ." | |
| "docker:build": "docker build --tag asyncapi/server-api .", | |
| "bump:version": "npm --no-git-tag-version --allow-same-version version $VERSION" |
please commit it as this is one more missing script that is required
|
Kudos, SonarCloud Quality Gate passed!
|
smoya
approved these changes
Oct 25, 2023
|
/rtm |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update release workflow.
Related issue(s)
Fixes #282
cc @derberg