-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add all protocol binding schemas #225
feat: add all protocol binding schemas #225
Conversation
Kudos, SonarCloud Quality Gate passed! |
Thanks @dalelane 🙏 /rtm |
@jonaslagoni why does it go to |
It was honestly more on the cautious side I choose to target that branch. Mainly because we still have no idea how to actually do the setup yet. So pairing it with a distant release in the future where we have time to figure out the right approach made the most sense 🙂 |
makes sense, but why not |
Hmm, that could have worked as well yes, did not really think about it. An upside to having it in the It will be more convenient for me to work on it from the |
So in the end it is up to you not me as you do the work on integrating bindings, you know what is your target. I just think it would be beneficial to introduce it earlier as yeah 3.0 is not happening too soon. |
@jonaslagoni @derberg Shall we also serve these via https://asyncapi.com/bindings as we do for schemas and definitions? |
I would say so yes 🙂 |
yup, there are just not yet integrated with main schema |
I created a follow up issue on this @jonaslagoni @derberg asyncapi/website#870 |
🎉 This PR is included in version 3.2.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR adds the JSON schema files from the bindings repository.
Things to figure out in this PR:
/bindings/protocol
, however, how do you reference specification extension? While they rarely, if ever change, usinghttps://raw.githubusercontent.com/asyncapi/asyncapi-node/v2.7.7/schemas/2.0.0.json#/definitions/specificationExtension
seems wrong in some sense, if it's part of spec v3 🤔Things to figure out after this PR:
Related issues
Partly solves asyncapi/bindings#113