fix: remove trailing comma from kafka and googlepubsub bindings for messages

[AceTheCreator]

Remove trailing commas from some bindings.

Bundling was broken because of it. CI before did not indicate any issues because of Node version. Now package lock is at version 2 and we will use Node 16 instead of 14 - no more issue with CI, in future we will see errors

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[derberg]

well spotted 🚀

please make sure to bump next major for parser with latest spec package

[AceTheCreator]

/rtm

[derberg]

@dalelane hey, we need your approval cause of kafka

@jonaslagoni I see you modified codeowners -> https://github.com/asyncapi/spec-json-schemas/blob/next-major-spec/CODEOWNERS to match bindings repo, but did you discuss it with particular code owners that you added to the list? I don't think there were added to the repo. Also don't think they need to be here.

[derberg]

imho we should have the same codeowners setup as in master, and if we wanna replicate setup from bindings, this needs a discussion and opt in from codeowners, as even in bindings repo, json schemas were owned by Khuda, not others

[jonaslagoni]

@dalelane hey, we need your approval cause of kafka

@jonaslagoni I see you modified codeowners -> https://github.com/asyncapi/spec-json-schemas/blob/next-major-spec/CODEOWNERS to match bindings repo, but did you discuss it with particular code owners that you added to the list? I don't think there were added to the repo. Also don't think they need to be here.

I mean we discussed it here: #239 (comment)

Think I forgot to ping codeowners afterward yeah.

But technically, I see it the other way around, this setup just mimics what we had in bindings, so technically no new changes need approval, except they have two repos now instead of one.

Not adding them as codeowners, would indeed need their approval IMO.

Also don't think they need to be here.

I completely disagree, otherwise, they are not really codeowners of bindings as they can only partial accept changes 🤷

[smoya]

LGTM! 🚀🌔

[derberg]

/rtm

[derberg]

@jonaslagoni ah, you're completely right, sorry, forgot about that discussion.

please ping affected maintainers in asyncapi/bindings#113 and I will invite them to this repo

[asyncapi-bot]

🎉 This PR is included in version 6.0.0-next-major-spec.9 🎉

The release is available on:

• npm package (@next-major-spec dist-tag)
• GitHub release

Your semantic-release bot 📦🚀