-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt Kafka bindings to v3 #446
Conversation
Signed-off-by: Laurent Broudoux <[email protected]>
@lbroudoux you need to re-target the PR to |
Oops... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the bindings to be validated as well, you need to adapt:
"kafka": { |
As well for message, operation and server 🙂
Signed-off-by: Laurent Broudoux <[email protected]>
Tests are failing but seem normal as http://asyncapi.com/bindings/kafka/v3-0.4.0/server.json is not yet deployed and available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Now replaced by #453 Could you all confirm we can cancel this one? |
yeh, makes sense to me |
Description
This is the companion PR to asyncapi/bindings#221.
As discussed and proposed here in issue #182, this PR:
0.4.0
inv2-0.4.0
andv3-0.4.0
to keep track of bindings changes related to AsyncAPI v3 or v3Another PR with specific schemas for v2 and v3 is on its way on
asyncapi/spec-json-schemas
.Related issue(s)
Relates to asyncapi/bindings#182