-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missed IBM MQ Operation Binding #840
fix: add missed IBM MQ Operation Binding #840
Conversation
Kudos, SonarCloud Quality Gate passed! |
@magicmatatjahu referencing also previous discussion about this in #605 |
@char0n Hah, thanks! I didn't see your issue. However @derberg added comment #836 (comment) so I don't know what I should think about this inconsistency across bindings. |
LGTM but I don't see an "Operation Binding Object" section on the |
yeah, I think we should make sure ibm mq is there too, for consistency reasons |
@fmvilas @derberg Pr on bindings repo asyncapi/bindings#149 |
Awesome, thanks @magicmatatjahu. Approved it but let's wait for @rcoppen and others to review it. |
PR asyncapi/bindings#149 is merged. It can be merged too :) cc @char0n |
@magicmatatjahu is there any adaption required for |
Nope, ParserJS treats bindings atm as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nice, asyncapi/bindings#149 is merged
lets get it in
Yup, feel free to merge. |
/rtm |
🎉 This PR is included in version 2.5.0-next-spec.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I found that we have forgot to define (probably it's a bug) definition for
IBM MQ Operation Binding
. I know that some bindings don't need to have definition for particular kind of binding, but we should have reserved keywords.I found it in review of #836 PR
cc @derberg @fmvilas and @dalelane you should be most interested :)