Merge branch 'master' into fix_#3250

.github/workflows/if-nodejs-pr-testing.yml

@@ -2,8 +2,10 @@
 name: PR testing - if Node project
 
 on:
-  pull_request:
+  pull_request_target:
     types: [opened, reopened, synchronize, ready_for_review]
+  push:
+    branches: [master]
 
 jobs:
   test-nodejs-pr:
@@ -40,6 +42,11 @@ jobs:
       - if: steps.should_run.outputs.shouldrun == 'true'
         name: Checkout repository
         uses: actions/checkout@v4
+        with:
+          # Checkout the merge commit instead of the pull request head commit for a pull request
+          # Fallback to the head commit if its not a pull request
+          ref: ${{ github.event.pull_request.number != '' && format('refs/pull/{0}/merge', github.event.pull_request.number) || github.ref }}
+
       - if: steps.should_run.outputs.shouldrun == 'true'
         name: Check if Node.js project and has package.json
         id: packagejson
@@ -59,7 +66,7 @@ jobs:
         name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: "${{ steps.nodeversion.outputs.version }}"
+          node-version: '${{ steps.nodeversion.outputs.version }}'
       - name: Install dependencies
         run: npm ci
       - if: steps.packagejson.outputs.exists == 'true'
@@ -72,3 +79,47 @@ jobs:
         name: Run release assets generation to make sure PR does not break it
         shell: bash
         run: npm run generate:assets --if-present
+
+      # Run the test:md script and capture output
+      - if: ${{ steps.packagejson.outputs.exists == 'true' && matrix.os == 'ubuntu-latest' }}
+        name: Run markdown checks
+        id: markdown_check
+        run: |
+          ERRORS=$(npm run test:md | sed -n '/Errors in file/,$p')
+          echo "markdown_output<<EOF" >> $GITHUB_OUTPUT
+          echo "$ERRORS" >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
+
+      # Post a comment using sticky-pull-request-comment
+      - name: Comment on PR with markdown issues
+        if: ${{ steps.markdown_check.outputs.markdown_output != '' && matrix.os == 'ubuntu-latest' }}
+        uses: marocchino/sticky-pull-request-comment@3d60a5b2dae89d44e0c6ddc69dd7536aec2071cd
+        with:
+          header: markdown-check-error
+          GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
+          message: |
+            ### Markdown Check Results
+
+            We found issues in the following markdown files:
+
+            ```
+            ${{ steps.markdown_check.outputs.markdown_output }}
+            ```
+
+      # Delete the comment if there are no issues
+      - if: ${{ steps.markdown_check.outputs.markdown_output == '' && matrix.os == 'ubuntu-latest' }}
+        name: Delete markdown check comment
+        uses: marocchino/sticky-pull-request-comment@3d60a5b2dae89d44e0c6ddc69dd7536aec2071cd
+        with:
+          header: markdown-check-error
+          delete: true
+          GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
+
+      - if: steps.packagejson.outputs.exists == 'true'
+        name: Upload Coverage to Codecov
+        uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673
+        with:
+          fail_ci_if_error: true
+          files: ./coverage/lcov.info
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true

.github/workflows/regenerate-meetings-and-videos.yml

@@ -1,6 +1,6 @@
 name: List everyday latest list of AsyncAPI Meetings, Newsroom Videos and Dashboard data.
 
-on: 
+on:
   workflow_dispatch:
   schedule:
   #every day at midnight
@@ -23,7 +23,7 @@ jobs:
         - name: Check package-lock version
           uses: asyncapi/.github/.github/actions/get-node-version-from-package-lock@master
           id: lockversion
-  
+
         - name: Use Node.js
           uses: actions/setup-node@v3
           with:
@@ -45,7 +45,7 @@ jobs:
             committer: asyncapi-bot <[email protected]>
             author: asyncapi-bot <[email protected]>
             title: 'chore: update meetings.json and newsrooom_videos.json'
-            branch: update-meetings/${{ github.job }}
+            branch: update-meetings/${{ github.sha }}
         - if: failure() # Only, on failure, send a message on the 94_bot-failing-ci slack channel
           name: Report workflow run status to Slack
           uses: 8398a7/action-slack@fbd6aa58ba854a740e11a35d0df80cb5d12101d8 #using https://github.com/8398a7/action-slack/releases/tag/v3.15.1
@@ -54,4 +54,4 @@ jobs:
             fields: repo,action,workflow
             text: 'AsyncAPI Meetings and Videos workflow failed'
           env:
-            SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CI_FAIL_NOTIFY }}
+            SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CI_FAIL_NOTIFY }}

components/campaigns/AnnouncementHero.tsx

@@ -1,10 +1,10 @@
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useMemo, useState } from 'react';
 
 import ArrowLeft from '../icons/ArrowLeft';
 import ArrowRight from '../icons/ArrowRight';
 import Container from '../layout/Container';
 import Banner from './AnnouncementBanner';
-import { banners } from './banners';
+import { banners, shouldShowBanner } from './banners';
 
 interface IAnnouncementHeroProps {
   className?: string;
@@ -21,15 +21,15 @@ interface IAnnouncementHeroProps {
 export default function AnnouncementHero({ className = '', small = false }: IAnnouncementHeroProps) {
   const [activeIndex, setActiveIndex] = useState(0);
 
-  const len = banners.length;
-  const numberOfVisibleBanners = banners.filter((banner) => banner.show).length;
+  const visibleBanners = useMemo(() => banners.filter((banner) => shouldShowBanner(banner.cfpDeadline)), [banners]);
+  const numberOfVisibleBanners = visibleBanners.length;
 
   const goToPrevious = () => {
-    setActiveIndex((prevIndex) => (prevIndex === 0 ? len - 1 : prevIndex - 1));
+    setActiveIndex((prevIndex) => (prevIndex === 0 ? numberOfVisibleBanners - 1 : prevIndex - 1));
   };
 
   const goToNext = () => {
-    setActiveIndex((prevIndex) => (prevIndex === len - 1 ? 0 : prevIndex + 1));
+    setActiveIndex((prevIndex) => (prevIndex === numberOfVisibleBanners - 1 ? 0 : prevIndex + 1));
   };
 
   const goToIndex = (index: number) => {
@@ -62,31 +62,28 @@ export default function AnnouncementHero({ className = '', small = false }: IAnn
         )}
         <div className='relative flex w-5/6 flex-col items-center justify-center gap-2'>
           <div className='relative flex min-h-72 w-full items-center justify-center overflow-hidden lg:h-[17rem] lg:w-[38rem]'>
-            {banners.map(
-              (banner, index) =>
-                banner.show && (
-                  <Banner
-                    key={index}
-                    title={banner.title}
-                    dateLocation={banner.dateLocation}
-                    cfaText={banner.cfaText}
-                    eventName={banner.eventName}
-                    cfpDeadline={banner.cfpDeadline}
-                    link={banner.link}
-                    city={banner.city}
-                    activeBanner={index === activeIndex % len}
-                    className={className}
-                    small={small}
-                  />
-                )
-            )}
+            {visibleBanners.map((banner, index) => (
+              <Banner
+                key={index}
+                title={banner.title}
+                dateLocation={banner.dateLocation}
+                cfaText={banner.cfaText}
+                eventName={banner.eventName}
+                cfpDeadline={banner.cfpDeadline}
+                link={banner.link}
+                city={banner.city}
+                activeBanner={index === activeIndex % numberOfVisibleBanners}
+                className={className}
+                small={small}
+              />
+            ))}
           </div>
           <div className='m-auto flex justify-center'>
-            {banners.map((banner, index) => (
+            {visibleBanners.map((banner, index) => (
               <div
                 key={index}
                 className={`mx-1 size-2 cursor-pointer rounded-full ${
-                  activeIndex % len === index ? 'bg-primary-500' : 'bg-gray-300'
+                  activeIndex % numberOfVisibleBanners === index ? 'bg-primary-500' : 'bg-gray-300'
                 }`}
                 onClick={() => goToIndex(index)}
               />

components/campaigns/banners.ts

@@ -3,7 +3,7 @@
  * @returns Whether the banner should be shown
  * @description Check if the current date is after the deadline
  */
-function shouldShowBanner(cfpDeadline: string) {
+export function shouldShowBanner(cfpDeadline: string) {
   const currentDate = new Date(); // G et the current date
   const deadline = new Date(cfpDeadline); // Convert the cfpDeadline string to a Date object
 
@@ -15,18 +15,14 @@ function shouldShowBanner(cfpDeadline: string) {
   return true;
 }
 
-const cfpDeadlineParis = '2024-10-12T06:00:00Z';
-const showBannerParis = shouldShowBanner(cfpDeadlineParis);
-
 export const banners = [
   {
-    title: "AsyncAPI Conf on Tour'24",
-    city: 'Paris',
-    dateLocation: '3rd - 5th of December, 2024 | France, Paris',
-    cfaText: 'Apply To Speak',
-    eventName: 'the end of Call for Speakers',
-    cfpDeadline: cfpDeadlineParis,
-    link: 'https://conference.asyncapi.com/venue/Paris',
-    show: showBannerParis
+    title: "AsyncAPI Online Conference'24",
+    city: 'YouTube',
+    dateLocation: '30th of October, 2024 | YouTube & LinkedIn',
+    cfaText: 'Join us Live',
+    eventName: 'the AsyncAPI Online Conference',
+    cfpDeadline: '2024-10-30T06:00:00Z',
+    link: 'https://www.youtube.com/live/F9wHxd-v2f0?si=kPCqgUzqAKC0FaqJ'
   }
 ];

components/newsroom/Newsroom.tsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { TwitterTimelineEmbed } from 'react-twitter-embed';
 
 import { HeadingLevel, HeadingTypeStyle } from '@/types/typography/Heading';
 import { ParagraphTypeStyle } from '@/types/typography/Paragraph';
@@ -69,19 +68,14 @@ export default function Newsroom() {
           </div>
         </div>
 
-        <div className='w-full flex-row items-stretch justify-between md:flex lg:w-3/4'>
+        <div className='w-full flex-row items-stretch justify-between md:flex md:h-120 lg:w-3/4'>
           <div className='relative flex w-full flex-col overflow-y-auto md:w-1/2'>
             <div className='min-h-0'>
-              <div className='md:t-0 md:b-0 md:l-0 md:r-0 size-full max-h-120 md:absolute'>
+              <div className='md:t-0 md:b-0 md:l-0 md:r-0 size-full md:absolute'>
                 <NewsroomArticle />
               </div>
             </div>
           </div>
-          <div className='w-full px-2 md:w-1/2 md:pl-4 md:pr-0'>
-            <div className='mx-auto mt-8 w-full rounded-xl shadow-md md:mt-0' data-testid='Newsroom-Twitter'>
-              <TwitterTimelineEmbed sourceType='profile' screenName='AsyncAPISpec' options={{ tweetLimit: '2' }} />
-            </div>
-          </div>
         </div>
       </div>
 

components/sponsors/SilverSponsorsList.ts

@@ -4,7 +4,7 @@ export const Silversponsors: SponsorType[] = [
   {
     name: 'Bump.sh',
     website: 'https://bump.sh/asyncapi?utm_source=asyncapi&utm_medium=referral&utm_campaign=sponsor',
-    altText: 'Bump',
+    altText: 'OpenAPI & AsyncAPI API docs - Bump.sh',
     imageSrc: '/img/sponsors/bumpsh.svg',
     imageClass: 'inline-block sm:h-9'
   },

config/adopters.yml

@@ -80,4 +80,16 @@
   useCase: Implementing a GitOps-based pipeline to enable self-service management of Kafka infrastructure, including access control management. Automation of AsyncAPI document governance ensures consistency in the infrastructure at the pull request level.
   resources:
     - title: "Slides: AsyncAPI For Platform Self-Service: A GitOps Tale"
-      link: https://drive.google.com/file/d/1y67PI8NaITPPwZAiDF2Zs7ISfcIpqMV8/view?usp=sharing
+      link: https://drive.google.com/file/d/1y67PI8NaITPPwZAiDF2Zs7ISfcIpqMV8/view?usp=sharing
+
+- companyName: Adidas
+  useCase: AsyncAPI is a standard for defining asynchronous APIs using Apache Kafka. AsyncAPI governed under official guidelines. AsyncAPI is promoted to be used for documentation and code generation.
+  resources:
+    - title: "Docs: AsyncAPI and Kafka Guidelines"
+      link: https://adidas.gitbook.io/api-guidelines/asynchronous-api-guidelines/kafka-asynchronous-guidelines/a_introduction/why-asyncapi
+
+- companyName: Morgan Stanley
+  useCase: AsyncAPI is promoted not only inside the company but also as a standard for FinOS Foundation for managing architecture as code.
+  resources:
+    - title: "Slides: Deploying WebSockets with AsyncAPI and Architecture as Code"
+      link: https://drive.google.com/file/d/1YzLwQZsMUXGwj_Lsqv-ZnvV2knuowWrS/view?usp=drive_link