Merge branch 'master' into buildPostTest

.github/workflows/if-nodejs-pr-testing.yml

@@ -2,7 +2,7 @@
 name: PR testing - if Node project
 
 on:
-  pull_request:
+  pull_request_target:
     types: [opened, reopened, synchronize, ready_for_review]
   push:
     branches: [master]
@@ -42,6 +42,11 @@ jobs:
       - if: steps.should_run.outputs.shouldrun == 'true'
         name: Checkout repository
         uses: actions/checkout@v4
+        with:
+          # Checkout the merge commit instead of the pull request head commit for a pull request
+          # Fallback to the head commit if its not a pull request
+          ref: ${{ github.event.pull_request.number != '' && format('refs/pull/{0}/merge', github.event.pull_request.number) || github.ref }}
+
       - if: steps.should_run.outputs.shouldrun == 'true'
         name: Check if Node.js project and has package.json
         id: packagejson
@@ -61,8 +66,7 @@ jobs:
         name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: "${{ steps.nodeversion.outputs.version }}"
-
+          node-version: '${{ steps.nodeversion.outputs.version }}'
       - name: Install dependencies
         run: npm ci
       - if: steps.packagejson.outputs.exists == 'true'
@@ -76,6 +80,41 @@ jobs:
         shell: bash
         run: npm run generate:assets --if-present
 
+      # Run the test:md script and capture output
+      - if: ${{ steps.packagejson.outputs.exists == 'true' && matrix.os == 'ubuntu-latest' }}
+        name: Run markdown checks
+        id: markdown_check
+        run: |
+          ERRORS=$(npm run test:md | sed -n '/Errors in file/,$p')
+          echo "markdown_output<<EOF" >> $GITHUB_OUTPUT
+          echo "$ERRORS" >> $GITHUB_OUTPUT
+          echo "EOF" >> $GITHUB_OUTPUT
+
+      # Post a comment using sticky-pull-request-comment
+      - name: Comment on PR with markdown issues
+        if: ${{ steps.markdown_check.outputs.markdown_output != '' && matrix.os == 'ubuntu-latest' }}
+        uses: marocchino/sticky-pull-request-comment@3d60a5b2dae89d44e0c6ddc69dd7536aec2071cd
+        with:
+          header: markdown-check-error
+          GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
+          message: |
+            ### Markdown Check Results
+
+            We found issues in the following markdown files:
+
+            ```
+            ${{ steps.markdown_check.outputs.markdown_output }}
+            ```
+
+      # Delete the comment if there are no issues
+      - if: ${{ steps.markdown_check.outputs.markdown_output == '' && matrix.os == 'ubuntu-latest' }}
+        name: Delete markdown check comment
+        uses: marocchino/sticky-pull-request-comment@3d60a5b2dae89d44e0c6ddc69dd7536aec2071cd
+        with:
+          header: markdown-check-error
+          delete: true
+          GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
+
       - if: steps.packagejson.outputs.exists == 'true'
         name: Upload Coverage to Codecov
         uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673

.github/workflows/regenerate-meetings-and-videos.yml

@@ -1,6 +1,6 @@
 name: List everyday latest list of AsyncAPI Meetings, Newsroom Videos and Dashboard data.
 
-on: 
+on:
   workflow_dispatch:
   schedule:
   #every day at midnight
@@ -23,7 +23,7 @@ jobs:
         - name: Check package-lock version
           uses: asyncapi/.github/.github/actions/get-node-version-from-package-lock@master
           id: lockversion
-  
+
         - name: Use Node.js
           uses: actions/setup-node@v3
           with:
@@ -45,7 +45,7 @@ jobs:
             committer: asyncapi-bot <[email protected]>
             author: asyncapi-bot <[email protected]>
             title: 'chore: update meetings.json and newsrooom_videos.json'
-            branch: update-meetings/${{ github.job }}
+            branch: update-meetings/${{ github.sha }}
         - if: failure() # Only, on failure, send a message on the 94_bot-failing-ci slack channel
           name: Report workflow run status to Slack
           uses: 8398a7/action-slack@fbd6aa58ba854a740e11a35d0df80cb5d12101d8 #using https://github.com/8398a7/action-slack/releases/tag/v3.15.1
@@ -54,4 +54,4 @@ jobs:
             fields: repo,action,workflow
             text: 'AsyncAPI Meetings and Videos workflow failed'
           env:
-            SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CI_FAIL_NOTIFY }}
+            SLACK_WEBHOOK_URL: ${{ secrets.SLACK_CI_FAIL_NOTIFY }}

components/newsroom/Newsroom.tsx

@@ -1,5 +1,4 @@
 import React from 'react';
-import { TwitterTimelineEmbed } from 'react-twitter-embed';
 
 import { HeadingLevel, HeadingTypeStyle } from '@/types/typography/Heading';
 import { ParagraphTypeStyle } from '@/types/typography/Paragraph';
@@ -69,19 +68,14 @@ export default function Newsroom() {
           </div>
         </div>
 
-        <div className='w-full flex-row items-stretch justify-between md:flex lg:w-3/4'>
+        <div className='w-full flex-row items-stretch justify-between md:flex md:h-120 lg:w-3/4'>
           <div className='relative flex w-full flex-col overflow-y-auto md:w-1/2'>
             <div className='min-h-0'>
-              <div className='md:t-0 md:b-0 md:l-0 md:r-0 size-full max-h-120 md:absolute'>
+              <div className='md:t-0 md:b-0 md:l-0 md:r-0 size-full md:absolute'>
                 <NewsroomArticle />
               </div>
             </div>
           </div>
-          <div className='w-full px-2 md:w-1/2 md:pl-4 md:pr-0'>
-            <div className='mx-auto mt-8 w-full rounded-xl shadow-md md:mt-0' data-testid='Newsroom-Twitter'>
-              <TwitterTimelineEmbed sourceType='profile' screenName='AsyncAPISpec' options={{ tweetLimit: '2' }} />
-            </div>
-          </div>
         </div>
       </div>
 

config/edit-page-config.json

@@ -13,7 +13,7 @@
   },
   {
     "value": "",
-    "href": "https://github.com/asyncapi/website/blob/master/pages"
+    "href": "https://github.com/asyncapi/website/blob/master/markdown"
   },
   {
     "value": "reference/extensions/",