Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding original svg icons to TSC members social handle links. #2663

Closed
sagarkori143 opened this issue Feb 17, 2024 · 5 comments · Fixed by #2669
Closed

Adding original svg icons to TSC members social handle links. #2663

sagarkori143 opened this issue Feb 17, 2024 · 5 comments · Fixed by #2669
Labels

Comments

@sagarkori143
Copy link
Contributor

sagarkori143 commented Feb 17, 2024

It's basically an UI enhancement. As discussed with @Mayaleeeee on slack, we need to change the SVG icons to original ones while they are being hovered.

How to Reproduce

Go to TSC Members and hover over any member's social handles. While hovering it generates a gray overlay to the icons.

Expected behavior

SVG icons should be replaced with original.

@sagarkori143
Copy link
Contributor Author

sagarkori143 commented Feb 17, 2024

Hey @Mayaleeeee !
I'm preparing to raise a PR super soon!

@its-kunal
Copy link
Contributor

Can you please assign me this issue?

@sagarkori143
Copy link
Contributor Author

Can you please assign me this issue?

Hey @its-kunal . I have already raised a PR for this issue. You can explore other issues.

@its-kunal
Copy link
Contributor

Yes, @sagarkori143 I know you already raised PR but you only mentioned due to health issues, would not be able to make changes as required till now.

@sagarkori143
Copy link
Contributor Author

Yes, @sagarkori143 I know you already raised PR but you only mentioned due to health issues, would not be able to make changes as required till now.

Yes @its-kunal . I'm OK now and I'll be updating the by today 😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants