fix: added the hover affect to icons #2669
Conversation
sagarkori143
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sagarkori143
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-2669--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Thank you @sagarkori143
This is really nice, I love it.
Any additional comment before I approve this? @akshatnema
|
@sagarkori143 any update on this? |
|
I'm having some health issues right now. I'll be updating the pr soon. |
|
Hey @akshatnema @sambhavgupta0705 @Mayaleeeee
|
I think @Mayaleeeee is the good one to answer this. Meanwhile, from my opinion, we can do that. Just make sure we follow the same SVG icon style for Twitter as we are doing for other social platforms. |
Yes, please. Thanks for calling my attention to it @akshatnema |
|
Please take a look! |
|
Please review. |
components/icons/GithubFilled.js
Outdated
There was a problem hiding this comment.
@sagarkori143 To provide hover effect inside the icons, can't we use CSS in the same icon to provide color to the icon, on hover?
There was a problem hiding this comment.
I did check about it and results came out as adding some custom classes and so on. But I will give it one more try. Will give you update about this very soon.
There was a problem hiding this comment.
I applied hover properties to the existing imported icons. Please have a look.
|
Hey @akshatnema please have a look 👀 |
|
/rtm |
closes: #2663
Here is the updated UI:
tsc.icons.mp4