-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable ids in list of features from landing page #1087
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1087--asyncapi-website.netlify.app/ |
Point 1 Point 2 Point 3 |
/rtm |
Ids are critical for Google Tag manager. They are used to track how often people click on certain links on landing pages. The purpose is to learn if these are even useful if people care and interact with them.
cc @alequetzalli this is a fix for the issue we discussed recently. So basically answer is: there is no global issue with website that
id
are disabled. It was just a problem with single component after brand migration. So you can easily useid
in tag manager@alequetzalli the problem is I have no idea how we can make sure
id
s are not removed by anyone in next PRs. Without automation it can happen in future that these are removed. The only option I see is making you codeowner fordocs
related code. But this is not best solution, just responsibility is delegated to you 😄Else? we could introduce automated tests. So start website instance, and check if
id
are there. You would have a config file where you have to write whatid
you add, and where are they expected to be 🤔