-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved the dropdown menu of filter section #1558
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1558--asyncapi-website.netlify.app/ |
hey @akshatnema I need help for design of selected items. |
@sambhavgupta0705 Regarding design and UI colors, kindly take help from @Mayaleeeee |
Thanks @akshatnema I appreciate this. @sambhavgupta0705 please let me know if you need my help. |
yes @Mayaleeeee I need help with what your color should be given to selected items,for now light blue is being given |
@sambhavgupta0705 tbh, present dropdown in your PR looks horrible to me in terms of design. You can make the dropdown from scratch also, using new designs and colors. Take help from @Mayaleeeee regarding this. |
@sambhavgupta0705 what's the status of this PR? |
@akshatnema PTAL |
@sambhavgupta0705 See, it's not necessary to extend the space for dropdown for each field. Instead, you can also overflow the dropdown over each other using z-index. I just want that the dropdown should look professional in terms of UI. You can take reference of https://flowbite.com/docs/components/dropdowns/#background-hover. |
ok @akshatnema I will keep this in mind. |
@Mayaleeeee any chance you can have a look? |
Yes, please, I will. |
I'm sorry I missed this 😥 I will take a look at it soon |
Hi @sambhavgupta0705 please take a look at this and feel free to let me know if you need any further assistance. screen-recording.1.webm |
@Mayaleeeee please provide the access of the figma file |
I just did. |
@Mayaleeeee the design is good but @akshatnema wanted something different.He said to make something like present in the preview but if he agrees then we can go with this one also. |
Any update??? |
|
Thanks @Mayaleeeee for designing the filter menu and I liked it as well. I personally liked the animation when we clicked on |
Description
Related issue(s)
Resolves #1318