-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add table of contents in case study #1673
feat: add table of contents in case study #1673
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@derberg I have made the required changes. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1673--asyncapi-website.netlify.app/ |
@Shurtu-gal When clicking on any of the TOC of the webpage, it doesn't get bold. Kindly look into it. |
@akshatnema Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect ❤️
@akshatnema please approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shurtu-gal This is the mobile view of the webpage and this error is on every mobile screen view. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1673--asyncapi-website.netlify.app/ |
@Mayaleeeee I have made the required changes. I am sorry that this took so much time 😢. |
No worries, @Shurtu-gal. So here are my reviews:
|
@Mayaleeeee The requested changes are done. |
Looks good. However, I noticed that the active color (black) does not remain visible on "More details about AsyncAPI" until I scroll down to "Schema". Please update this to ensure it remains visible. @Shurtu-gal |
@Mayaleeeee Done now the parent remains active until another nav item at the same level doesn't pass through the viewport. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Shurtu-gal , I do have a feature issue here 😅. As we scroll down, the menus should get expanded and closed automatically. But don't worry for it in this PR. We can target this feature in another PR or issue. LGTM ✔️
@Mayaleeeee your review required!!!! |
I will try to resolve this too and open a PR as soon as possible. |
imho we can merge, Maya had enough time to do review. If there are some issues, we can always follow up later |
@derberg, @Mayaleeeee has requested changes on this PR. She has to approve it then. Should I bypass the branch protections to merge the PR? |
Yes, please. If I see any changes that needs to be made from the laptop view, I'll update this comment. |
@Mayaleeeee Can you please approve the PR, since you requested changes before? |
Description
Related issue(s)
Fixes #1502 #1505