Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved what the experts are saying section #1696 #1697

Closed
wants to merge 2 commits into from

Conversation

SumantxD
Copy link
Contributor

As instructed i have created a carousel for the testimonials section which has the following feature

  • testimonials automatically rotate, showcasing one testimonial at a time
  • pagination feature have been added along with a pause feature so that the users can navigate through the testimonies at their own pace manually
  • additionally a full screen feature has been added, so that the user can view individual testimonials on full screen

@netlify
Copy link

netlify bot commented May 20, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5ccee4e
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/646906f1f3c3d50008dd9842
😎 Deploy Preview https://deploy-preview-1697--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SumantxD
Copy link
Contributor Author

SumantxD commented May 20, 2023

working video

@SumantxD
Copy link
Contributor Author

AsyncAPI.Initiative.for.event-driven.APIs.mp4

Copy link
Member

@SumantxD Is there any issue/discussion opened related to this PR?

@SumantxD
Copy link
Contributor Author

@SumantxD Is there any issue/discussion opened related to this PR?

Yes @akshatnema this PR was realted to this issue

@derberg
Copy link
Member

derberg commented Jun 22, 2023

isn't it the same as #1704?

@SumantxD
Copy link
Contributor Author

isn't it the same as #1704?

Yes, didn't knew back then that the issues are not assigned to contributors 🙁
ended up solving the same issue which collided with #1704

@derberg
Copy link
Member

derberg commented Jun 27, 2023

closing in favour of #1697

@derberg derberg closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants