Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blog): adding 3 New Articles as Blog Posts #1805

Merged
merged 64 commits into from
Aug 11, 2023

Conversation

ivangsa
Copy link
Contributor

@ivangsa ivangsa commented Jun 19, 2023

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3dce3fc
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64d62456641d71000814d7c6
😎 Deploy Preview https://deploy-preview-1805--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@thulieblack thulieblack changed the title Adding 3 New Articles as Blog Posts chore: adding 3 New Articles as Blog Posts Jun 19, 2023
@github-actions
Copy link

github-actions bot commented Jun 19, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 23
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1805--asyncapi-website.netlify.app/


- First write the OpenAPI definition, collaborating between API providers and API consumers.
- Then use OpenAPI Generator, either the maven plugin or a CLI, to generate some DTOs and interfaces from your OpenAPI definition.
- Implementing the generated interfaces you can create a service for the API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Implementing the generated interfaces you can create a service for the API.
- You can create a service for the API by implementing the generated interfaces.

@thulieblack
Copy link
Member

@alequetzalli please help with the final editorial review

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ivangsa @thulieblack, we already have published versions of the blog, why there is a need to republish it via the AsyncAPI website? We can add the required articles/blogs in newsroom section as well.

@thulieblack
Copy link
Member

Hey @akshatnema, we are reposting them onto the blog, but if newsroom is the way to go, then it should be fine 👌🏿

@ivangsa
Copy link
Contributor Author

ivangsa commented Jul 14, 2023

I got the suggestion to repost it to the blog similar to this PR https://github.com/asyncapi/website/blob/master/pages/blog/openapi-vs-asyncapi-burning-questions.md?plain=1#L6

@thulieblack
Copy link
Member

I think Lukasz once mentioned how we could repost and use canonical something something, @derberg

@akshatnema
Copy link
Member

We have multiple ways to do that, it's important that in which way we are getting more exposure to our content. So, probably @derberg will give proper insights on it. But to the fact that, Articles which are not part of AsyncAPI blog should be present inside Article section of Newsroom page, else we don't have any other usage for that component.

@derberg
Copy link
Member

derberg commented Jul 19, 2023

@akshatnema the newsroom is fine for articles from authors that do not wish to repost

but if author wants to repost, and we already support canonical metadata in front matter then the way to go is - repost. Blog is for the community. If @ivangsa is an AsyncAPI tools builder and wants wider adoption and discussion - he should be able to repost

@ivangsa
Copy link
Contributor Author

ivangsa commented Aug 2, 2023

Hey, At least 1 approving review is required to merge this pull request.

thulieblack
thulieblack previously approved these changes Aug 2, 2023
@thulieblack
Copy link
Member

Yeah I think since everything has been cleared up, we can merge this cc @derberg

@derberg
Copy link
Member

derberg commented Aug 2, 2023

maybe the publish date for articles should be updated to more recent? like schedule it for next week so we do not release them this week when July update comes up?

@thulieblack
Copy link
Member

makes sense. will schedule for next week then

@ivangsa
Copy link
Contributor Author

ivangsa commented Aug 2, 2023

Thanks @thulieblack for making our life easier!! <3

Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged!!

@thulieblack
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 052ddf7 into asyncapi:master Aug 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants